MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015477CMakeModulespublic2015-03-26 06:112015-11-02 09:13
Reporterj.kreuzberger 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformIntelx64OSWindowsOS Version7
Product VersionCMake 3.2.1 
Target VersionCMake 3.2.2Fixed in VersionCMake 3.2.2 
Summary0015477: FindMFC.cmake warning due to POLICY CMP0054
Descriptioncmake_required_version is 3.0.0
during migration to 3.2.1 the POLICY CMP0054
gives a warning in FindMFC.cmake line 39

Question is if i set the policy to "NEW", does this affect the FindMFC.cmake behaviour on FindMFC?
Steps To Reproducecmake configure step
Additional InformationCannot clearly check the behaviour for FindMFC.cmake
cause i am on a linux machine and currently have no environment with
cmake 3.2, mfc installed and visual studio professional

TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-26 06:11j.kreuzbergerNew Issue
2015-03-26 09:05Brad KingNote Added: 0038296
2015-03-26 09:08Brad KingNote Added: 0038297
2015-03-26 09:09Brad KingAssigned To => Brad King
2015-03-26 09:09Brad KingStatusnew => resolved
2015-03-26 09:09Brad KingResolutionopen => fixed
2015-03-26 09:09Brad KingFixed in Version => CMake 3.3
2015-03-26 09:09Brad KingTarget Version => CMake 3.3
2015-04-16 08:44Brad KingFixed in VersionCMake 3.3 => CMake 3.2.2
2015-04-16 08:44Brad KingTarget VersionCMake 3.3 => CMake 3.2.2
2015-04-16 08:45Brad KingNote Added: 0038532
2015-11-02 09:13Robert MaynardNote Added: 0039775
2015-11-02 09:13Robert MaynardStatusresolved => closed

Notes
(0038296)
Brad King   
2015-03-26 09:05   
It looks like the warning only happens on the second configuration or later.

I've fixed it here:

 FindMFC: Use if(DEFINED) to simplify condition
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dcf29800 [^]

Next I'll check how the policy should be set for 3.2.1.
(0038297)
Brad King   
2015-03-26 09:08   
It should be okay to set the policy to NEW. It will silence the warning at the cost of checking for MFC on every re-configuration with any version of CMake in the range 3.1.0 to 3.2.1. Releases with the fix in 0015477:0038296 will no longer re-check.
(0038532)
Brad King   
2015-04-16 08:45   
The fix linked in 0015477:0038296 has been merged to the 'release' branch and included in 3.2.2.
(0039775)
Robert Maynard   
2015-11-02 09:13   
Closing resolved issues that have not been updated in more than 4 months.