MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015379CMakeCTestpublic2015-01-28 10:252015-11-02 09:15
ReporterMarco Nolden 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.1.1 
Target VersionCMake 3.1.2Fixed in VersionCMake 3.1.2 
Summary0015379: [PATCH] CTest does not recognize recent gmake's messages as errors
DescriptionThe "No rule to make target" error message of gmake is not correctly recognized since GNU make changed the quoting style [1] . Example:

gmake[5]: *** No rule to make target '/space/dartclients/clang/MITK-Superbuild-Release-nightly/OpenCV-build/lib/libopencv_videostab.so.2.4.8', needed by 'lib/libITKVideoBridgeOpenCV-4.5.so.1'. Stop.

is not recognized so the superbuild continues an leads to an incorrect report on the dashboard.

I attached a fix, would be great if this could go into CMake 3.2
Steps To ReproduceHappens always with a problematic superbuild and recent versions of GNU make
Additional Information[1]: http://git.savannah.gnu.org/cgit/make.git/commit/remake.c?id=23c2b99e9d23e726ede9442728272616e66d416f [^]
TagsNo tags attached.
Relationships
Attached Filespatch 0001-cmCTestBuildHandler-fix-for-newer-GNU-style-error-me.patch (1,264) 2015-01-28 10:25
https://public.kitware.com/Bug/file/5368/0001-cmCTestBuildHandler-fix-for-newer-GNU-style-error-me.patch
Issue History
Date ModifiedUsernameFieldChange
2015-01-28 10:25Marco NoldenNew Issue
2015-01-28 10:25Marco NoldenFile Added: 0001-cmCTestBuildHandler-fix-for-newer-GNU-style-error-me.patch
2015-01-28 10:41Brad KingNote Added: 0037854
2015-01-28 10:41Brad KingAssigned To => Brad King
2015-01-28 10:41Brad KingStatusnew => resolved
2015-01-28 10:41Brad KingResolutionopen => fixed
2015-01-28 10:41Brad KingFixed in Version => CMake 3.2
2015-01-28 10:41Brad KingTarget Version => CMake 3.2
2015-02-05 09:23Brad KingNote Added: 0037921
2015-02-05 09:23Brad KingFixed in VersionCMake 3.2 => CMake 3.1.2
2015-02-05 09:23Brad KingTarget VersionCMake 3.2 => CMake 3.1.2
2015-05-27 11:55Brad KingNote Added: 0038807
2015-11-02 09:15Robert MaynardNote Added: 0039826
2015-11-02 09:15Robert MaynardStatusresolved => closed

Notes
(0037854)
Brad King   
2015-01-28 10:41   
Applied, thanks:

 ctest_build: Update GNU make error message matching
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d52b5f88 [^]

For future contributions please read CONTRIBUTING.rst and send patches to the mailing list.
(0037921)
Brad King   
2015-02-05 09:23   
I merged this fix into the 'release' branch for 3.1.2.
(0038807)
Brad King   
2015-05-27 11:55   
This change broke matching of these messages altogether by leaving an extra escape sequence in the regexes. Fixed here:

 ctest_build: Fix regression in GNU make error message matching
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=44a4e545 [^]
(0039826)
Robert Maynard   
2015-11-02 09:15   
Closing resolved issues that have not been updated in more than 4 months.