MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015070CMakeCMakepublic2014-08-07 15:022015-05-04 09:05
ReporterVitali 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformApple MacOSOS XOS Version10.4.10
Product VersionCMake 3.0 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0015070: CMake doesn't escape # properly in add_compile_options with Makefile generator
Descriptionadd_compile_options appears to generate the wrong escape sequence for:
add_compile_options("-Wno-error=#warnings")

when used in conjuction with the Makefile generator
Steps To Reproduceadd_compile_options("-Wno-error=#warnings")

Use makefile generator

Look at flags.make:
CXX_FLAGS = ... "-Wno-error=#warnings" ...
It should be:
CXX_FLAGS = "-Wno-error=\#warnings"
due to shell-expansion (otherwise # gets treated as a comment).
Additional InformationNo amount of escaping in CMake fixes this.
It looks like CMake is already aware of \ escaping for the Makefile generator but not for #:

add_compile_options("-Wno-error=\#warnings")
CXX_FLAGS = ... "-Wno-error=#warnings" ...

add_compile_options("-Wno-error=\\#warnings")
CXX_FLAGS = ... "-Wno-error=\\#warnings" ...

add_compile_options("-Wno-error=\\\#warnings")
CXX_FLAGS = ... "-Wno-error=\\#warnings" ...
TagsNo tags attached.
Relationships
related to 0014547closed Kitware Robot Unix Makefile generator won't escape '#' 
related to 0013562closed Kitware Robot Incorrect Makefiles generated for paths containing '#' 
has duplicate 0015285closed  Cannot escape "#" in add_compile_options 
related to 0015322closed  Double backslash to escape '#' in CMAKE_CXX_FLAGS no longer works 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-07 15:02VitaliNew Issue
2014-08-07 16:01Brad KingNote Added: 0036577
2014-08-12 14:01Brad KingNote Added: 0036604
2014-12-04 14:46Brad KingRelationship addedrelated to 0015285
2014-12-04 14:47Brad KingRelationship replacedhas duplicate 0015285
2014-12-04 14:48Brad KingRelationship addedrelated to 0014547
2014-12-04 14:48Brad KingRelationship addedrelated to 0013562
2014-12-04 14:51Brad KingAssigned To => Brad King
2014-12-04 14:51Brad KingStatusnew => resolved
2014-12-04 14:51Brad KingResolutionopen => fixed
2014-12-04 14:51Brad KingFixed in Version => CMake 3.1
2014-12-04 14:51Brad KingTarget Version => CMake 3.1
2014-12-22 13:21Brad KingRelationship addedrelated to 0015322
2015-05-04 09:05Robert MaynardNote Added: 0038704
2015-05-04 09:05Robert MaynardStatusresolved => closed

Notes
(0036577)
Brad King   
2014-08-07 16:01   
The _FLAGS variables are written here:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmMakefileTargetGenerator.cxx;hb=v3.0.0#l359 [^]

The flags that come from COMPILE_OPTIONS are computed by cmLocalGenerator::AddCompileOptions here:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalGenerator.cxx;hb=v3.0.0#l1447 [^]

which uses cmLocalGenerator::AppendFlagEscape:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalGenerator.cxx;hb=v3.0.0#l2347 [^]

which uses cmLocalGenerator::EscapeForShell.

That is meant for escaping things directly in the shell command part of a make rule. However, in this case it needs to escape for Make syntax in a variable assignment. That does not care about quoting so an extra layer of escaping is needed.
(0036604)
Brad King   
2014-08-12 14:01   
I've drafted a commit to fix this:

 Makefile: Handle '#' in COMPILE_OPTIONS
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fbf7a929 [^]
(0038704)
Robert Maynard   
2015-05-04 09:05   
Closing resolved issues that have not been updated in more than 4 months.