MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014927CMakeCMakepublic2014-05-22 13:402014-11-03 08:38
ReporterMark Salisbury 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.12.2 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0014927: Visual Studio 7-9 generators case bools incorrectly
DescriptionIn attempting to use a CMake generated .vcproj file with a local tool that parses .vcproj files I discovered that CMake cases boolean values "TRUE" and "FALSE".

.NET XML parsing chokes on anything but "true", "false", "0", "1". (See http://blogs.msdn.com/b/helloworld/archive/2009/04/03/workaround-to-deserialize-true-false-using-xmlserializer.aspx [^])

Visual Studio natively saves boolean values in .vcproj files with lowercase ("true"/"false"). I assume there would be no harm in modifying CMake to use lowercase bools.

I will submit a patch to address this issue.
Steps To ReproduceGenerate any Visual Studio 7-9 project file.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Modified-Visual-Studio-7-9-generators-lowercase-bool.patch (8,250) 2014-05-28 16:25
https://public.kitware.com/Bug/file/5158/0001-Modified-Visual-Studio-7-9-generators-lowercase-bool.patch
Issue History
Date ModifiedUsernameFieldChange
2014-05-22 13:40Mark SalisburyNew Issue
2014-05-22 13:40Mark SalisburyFile Added: 0001-Modified-Visual-Studio-7-9-generators-lowercase-bool.patch
2014-05-22 13:47Mark SalisburyNote Added: 0035914
2014-05-22 13:49Brad KingFile Deleted: 0001-Modified-Visual-Studio-7-9-generators-lowercase-bool.patch
2014-05-22 13:50Brad KingNote Added: 0035915
2014-05-28 16:25Mark SalisburyFile Added: 0001-Modified-Visual-Studio-7-9-generators-lowercase-bool.patch
2014-05-28 16:26Mark SalisburyNote Added: 0035959
2014-05-29 10:01Brad KingNote Added: 0035968
2014-05-29 10:01Brad KingAssigned To => Brad King
2014-05-29 10:01Brad KingStatusnew => resolved
2014-05-29 10:01Brad KingResolutionopen => fixed
2014-05-29 10:01Brad KingFixed in Version => CMake 3.1
2014-05-29 10:01Brad KingTarget Version => CMake 3.1
2014-11-03 08:38Robert MaynardNote Added: 0037151
2014-11-03 08:38Robert MaynardStatusresolved => closed

Notes
(0035914)
Mark Salisbury   
2014-05-22 13:47   
Oops. Should have previewed first patch before I submitted. It included files I did not mean to include.
(0035915)
Brad King   
2014-05-22 13:50   
Re 0014927:0035914: Okay, I deleted the incorrect patch. Please attach again.
(0035959)
Mark Salisbury   
2014-05-28 16:26   
OK, uploaded again. Thanks Brad.
(0035968)
Brad King   
2014-05-29 10:01   
Applied, thanks:

 VS: Use lower-case boolean values in VS 7-9
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b684ce58 [^]
(0037151)
Robert Maynard   
2014-11-03 08:38   
Closing resolved issues that have not been updated in more than 4 months.