MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014889CMakeCPackpublic2014-04-18 11:162014-10-06 10:33
ReporterNicolas H. 
Assigned ToNils Gladitz 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSwindowsOS Versionall
Product Version 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0014889: Cpack crashes when issuing a bad Wix Patch
Descriptioni'm trying to patch a wix script with a bad xml id
Steps To Reproducereproduced on master (patch only implemented in cmake 3)

add SET(CPACK_WIX_PATCH_FILE file.xml) to your project
issue a bad xml fragment ID (on that wixGenerator cannot find)
cpack crash
Additional Informationthere is an issue when creating cmCPackWIXGenerator object. Patch object is not defined, so a null pointer is passed at construction time.
I've fixed it, patch is attached
TagsNo tags attached.
Relationships
Attached Filespatch 0001-fixed-cpack-wix-patch-issue-due-to-bad-logger-initia.patch (4,705) 2014-04-18 11:16
https://public.kitware.com/Bug/file/5132/0001-fixed-cpack-wix-patch-issue-due-to-bad-logger-initia.patch
Issue History
Date ModifiedUsernameFieldChange
2014-04-18 11:16Nicolas H.New Issue
2014-04-18 11:16Nicolas H.File Added: 0001-fixed-cpack-wix-patch-issue-due-to-bad-logger-initia.patch
2014-04-18 11:19Brad KingAssigned To => Nils Gladitz
2014-04-18 11:19Brad KingStatusnew => assigned
2014-04-21 14:04Brad KingNote Added: 0035755
2014-04-21 14:04Brad KingProduct VersionCMake 2.8.12.2 =>
2014-04-21 14:04Brad KingTarget Version => CMake 3.1
2014-04-21 14:43Nils GladitzNote Added: 0035758
2014-04-21 14:43Nils GladitzStatusassigned => resolved
2014-04-21 14:43Nils GladitzResolutionopen => fixed
2014-04-22 08:33Brad KingFixed in Version => CMake 3.1
2014-10-06 10:33Robert MaynardNote Added: 0036982
2014-10-06 10:33Robert MaynardStatusresolved => closed

Notes
(0035755)
Brad King   
2014-04-21 14:04   
The offending code appears to be introduced in post-3.0 development here:

 CPackWIX: refactor and cleanup
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6fcd835c [^]

Does the recent commit:

 CPackWIX: Delay creation of cmWIXPatch until CPack has initialized Logger
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cb59f5da [^]

resolve this?
(0035758)
Nils Gladitz   
2014-04-21 14:43   
Yes, the issue does not manifest in v3.0.0-rc4. The commit fixes it for master.
Thanks for the report!
(0036982)
Robert Maynard   
2014-10-06 10:33   
Closing resolved issues that have not been updated in more than 4 months.