MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014796CMakeCMakepublic2014-03-07 10:212016-01-04 11:52
ReporterJussiP 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformAnyOSAnyOS VersionAny
Product VersionCMake 2.8.12.2 
Target VersionCMake 3.4Fixed in VersionCMake 3.4 
Summary0014796: LINK_DEPENDS should work with Ninja backend
DescriptionDescription for LINK_DEPENDS says this:

This property is ignored by non-Makefile generators.

However Ninja is meant to be a drop-in replacement for Make so this should work on it as well.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-07 10:21JussiPNew Issue
2014-03-07 10:36Robert MaynardNote Added: 0035338
2014-03-10 10:54Brad KingNote Added: 0035358
2014-04-13 05:29Peter KuemmelSeverityminor => feature
2014-04-13 05:29Peter KuemmelStatusnew => confirmed
2015-08-05 04:19timxxNote Added: 0039237
2015-08-05 14:13Brad KingNote Added: 0039244
2015-08-05 14:13Brad KingStatusconfirmed => resolved
2015-08-05 14:13Brad KingResolutionopen => fixed
2015-08-05 14:13Brad KingFixed in Version => CMake 3.4
2015-08-05 14:13Brad KingTarget Version => CMake 3.4
2016-01-04 11:52Robert MaynardNote Added: 0040107
2016-01-04 11:52Robert MaynardStatusresolved => closed

Notes
(0035338)
Robert Maynard   
2014-03-07 10:36   
Ninja isn't a drop in replacement for make.
(0035358)
Brad King   
2014-03-10 10:54   
The place to implement this is likely in cmNinjaTargetGenerator::ComputeLinkDeps:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmNinjaTargetGenerator.cxx;hb=v3.0.0-rc1#l245 [^]

It should look up the value of the target LINK_DEPENDS property the way the Makefile generator does here:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmMakefileTargetGenerator.cxx;hb=v3.0.0-rc1#l1658 [^]
(0039237)
timxx   
2015-08-05 04:19   
Is there any plan to fix this bug?
Or a workaround for fixing without touch the cmake source code? :(
(0039244)
Brad King   
2015-08-05 14:13   
Fixed:

 Ninja: Honor the LINK_DEPENDS target property
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=43c94281 [^]
(0040107)
Robert Maynard   
2016-01-04 11:52   
Closing resolved issues that have not been updated in more than 4 months.