MantisBT - CMake
View Issue Details
0014773CMakeModulespublic2014-02-26 05:582014-10-06 10:32
Derek Chow 
 
lowminoralways
closedno change required 
Windows
CMake 2.8.12.2 
 
0014773: Fix bug Boost_FOUND could be false when version specified and using -GNinja
See https://gitorious.org/cmake/cmake/commit/accd042 [^] on related fix.

The problem comes into play when we specify the Ninja generator (-GNinja) and CMake whilst it wraps around my MSVC90 compiler, CMake doesn't initialise the MSVC90 variable so the above fix doesn't quite help.

Given ninja support is "experimental" I'm not sure this is a bug (whether the MSVC90 variable should be set if ninja is wrapping MSVC90) so marked this issue as minor/low priority whilst I use the boost_COMPILER workaround).
No tags attached.
Issue History
2014-02-26 05:58Derek ChowNew Issue
2014-02-26 08:10Brad KingNote Added: 0035204
2014-03-04 09:02Derek ChowNote Added: 0035245
2014-03-04 09:40Brad KingNote Added: 0035246
2014-03-04 09:40Brad KingStatusnew => resolved
2014-03-04 09:40Brad KingResolutionopen => no change required
2014-10-06 10:32Robert MaynardNote Added: 0036930
2014-10-06 10:32Robert MaynardStatusresolved => closed

Notes
(0035204)
Brad King   
2014-02-26 08:10   
Are you saying that MSVC90 is not defined when using the Ninja generator? It should be. We have a nightly test with Ninja + VS 9 and it outputs

 MSVC90='1' is defined

from the CheckCompilerRelatedVariables test.
(0035245)
Derek Chow   
2014-03-04 09:02   
Oh terribly sorry!

In the end it was my fault for not using the vcvarsall.bat to setup the path for MSVC's cl.exe, etc.
(0035246)
Brad King   
2014-03-04 09:40   
Okay, thanks for reporting back.
(0036930)
Robert Maynard   
2014-10-06 10:32   
Closing resolved issues that have not been updated in more than 4 months.