MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014769CMakeCPackpublic2014-02-24 09:042015-04-06 09:07
ReporterJavier 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSLinuxOS Version
Product VersionCMake 2.8.12.2 
Target VersionCMake 3.2Fixed in VersionCMake 3.2 
Summary0014769: CPackRPM: need CPACK_RPM_<Component>_PACKAGE_<PRE/POST>_REQUIRES
DescriptionWe need to support the addition of PRE and POST Requires per component.

For instance:

CPACK_RPM_COMPONENTA_PACKAGE_PRE_REQUIRES="postgres >= 1.0"

Should generate this header:

Requires(pre): postgres >= 1.0

Steps To Reproduce
Additional InformationHere is the RPM documentation link:

http://www.rpm.org/wiki/PackagerDocs/Dependencies#ScriptletDependencies [^]

TagsNo tags attached.
Relationships
Attached Filespatch pre_post_rpm_install.patch (2,638) 2014-10-07 13:37
https://public.kitware.com/Bug/file/5270/pre_post_rpm_install.patch
Issue History
Date ModifiedUsernameFieldChange
2014-02-24 09:04JavierNew Issue
2014-10-07 13:37Evgeny KalishenkoFile Added: pre_post_rpm_install.patch
2014-10-07 13:40Evgeny KalishenkoNote Added: 0037001
2014-10-08 11:20Brad KingNote Added: 0037006
2014-11-21 16:22Evgeny KalishenkoNote Added: 0037253
2014-11-25 09:11Brad KingNote Added: 0037273
2014-11-25 09:11Brad KingStatusnew => resolved
2014-11-25 09:11Brad KingResolutionopen => fixed
2014-11-25 09:11Brad KingFixed in Version => CMake 3.2
2014-11-25 09:11Brad KingTarget Version => CMake 3.2
2015-04-06 09:07Robert MaynardNote Added: 0038446
2015-04-06 09:07Robert MaynardStatusresolved => closed

Notes
(0037001)
Evgeny Kalishenko   
2014-10-07 13:40   
Hi, I've created the patch that seems to solve the problem, it's attached. Should I do the whole stages from http://www.cmake.org/Wiki/CMake/Git/Develop [^] or it's so small that can be reviewed and applied by CPack developer?
(0037006)
Brad King   
2014-10-08 11:20   
Re 0014769:0037001: Thanks for working on a patch. The best contribution path is documented in CONTRIBUTING.rst at the top of the CMake source tree in Git. Please read that and send a "git format-patch"-formatted patch to the mailing list:

 http://www.cmake.org/mailman/listinfo/cmake-developers [^]

That will get a broader audience for review than the issue tracker.
(0037253)
Evgeny Kalishenko   
2014-11-21 16:22   
I think the issue can be resolved after approving the patch http://www.cmake.org/pipermail/cmake-commits/2014-October/020907.html [^]
(0037273)
Brad King   
2014-11-25 09:11   
Re 0014769:0037253: Yes, thanks. Those were committed here:

 CPackRPM: Support pre(post) install script requirements
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=add4e50d [^]

 CPackRPM: Support PREUN and POSTUN requirements
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9ed546ff [^]
(0038446)
Robert Maynard   
2015-04-06 09:07   
Closing resolved issues that have not been updated in more than 4 months.