MantisBT - CMake
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0014597	CMake	CMake	public	2013-11-26 04:17	2016-06-10 14:31

Reporter	tisi
Assigned To	Kitware Robot
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	moved
Platform	x86	OS	Windows	OS Version	7
Product Version	CMake 2.8.12
Target Version		Fixed in Version

Summary	0014597: Ninja: several add_custom_command(Target ... POST_BUILD ...) may lead to a command which breaks the command line limit
Description	We encountered the following problem with a project for an embedded microcontroller, but it is reproducable on normal x86 machines. We use the command add_custom_command(Target <Target> POST_BUILD <Commands>) to run severeal commands after linking (some hex-file manipulations like calculating crc32, moving of memory and so on). In the past we used the makefile generator and our project worked fine, but we want to switch to ninja for some other reasons. We found the following issue: The ninja generator combines the linker command and all the add_custom_commands to one large command (all commands are combinded by &&, so linker-command && custom1 && custom2 && custom3 && ...), which breaks the command line limit of windows (8kB). I think the same issue would be true on linux with an higher limit (i think 32kb). Is it possible to change the behavior of the generator to support something like that (e.g. intermediate targets for the add_custom_commands)? Right now we make a shell script and use only one add_custom_command, but its not nice that there is a different behavior between the make and the ninja build at all.
Steps To Reproduce	I've uploaded a file with a cmake project, which demonstrates that. You will need a c compiler, but it doesn't matter which one. Just run cmake -G "Ninja" <source_path> && ninja on Windows and you should see the issue.
Additional Information
Tags	No tags attached.
Relationships
Attached Files	AddCustomCommandDemo.zip (985) 2013-11-26 04:17 https://public.kitware.com/Bug/file/4967/AddCustomCommandDemo.zip

Issue History
Date Modified	Username	Field	Change
2013-11-26 04:17	tisi	New Issue
2013-11-26 04:17	tisi	File Added: AddCustomCommandDemo.zip
2013-11-26 05:42	Peter Kuemmel	Assigned To	=> Peter Kuemmel
2013-11-26 05:42	Peter Kuemmel	Status	new => assigned
2013-11-26 05:45	Peter Kuemmel	Note Added: 0034562
2013-11-26 05:45	Peter Kuemmel	Status	assigned => confirmed
2014-04-13 05:48	Peter Kuemmel	Assigned To	Peter Kuemmel =>
2014-06-16 11:24	Alexandre Chassany	Note Added: 0036204
2015-01-28 16:00	Alexandre Chassany	Note Added: 0037855
2016-06-10 14:29	Kitware Robot	Note Added: 0042433
2016-06-10 14:29	Kitware Robot	Status	confirmed => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:29	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed

Notes