MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014402CMakeCMakepublic2013-09-12 17:252014-06-02 08:37
ReporterCedric Perthuis 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.11.2 
Target VersionCMake 3.0Fixed in VersionCMake 3.0 
Summary0014402: Replace "Visual Studio 11" by Visual Studio 2012" in cmake-gui
DescriptionThe current naming convention in cmake-gui and probably everywhere is too confusing for users.

It took me a long time to figure out why I couldn't get the "Visual Studio 12" config working... I hadn't installed VS 2013 preview on my machine, and intended to build a project for VS 2012.

There must have been some debate about this already. When showing a name in a GUI, it's probably best to use the commercial name and the name everyone refers too.

Alternatively, an ok middle ground solution would be to call it
Visual Studio 2012 (VS11).
it took me half an hour of internet searches to find someone pointed out that the names were confusing and that Visual Studio 11 was what I wanted.

Thanks!


Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0010158closed Brad King Incorrect name of Visual Studio .NET 2005 product and Visual Studio 10/2010 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-12 17:25Cedric PerthuisNew Issue
2013-09-12 18:30David ColeRelationship addedrelated to 0010158
2013-09-12 18:30David ColeNote Added: 0033812
2013-09-13 08:34Brad KingNote Added: 0033816
2013-09-13 08:38Brad KingStatusnew => backlog
2013-09-13 12:20Cedric PerthuisNote Added: 0033819
2013-11-02 09:01Stephen KellyNote Added: 0034312
2013-11-02 14:15Brad KingNote Added: 0034336
2013-11-02 14:15Brad KingAssigned To => Brad King
2013-11-02 14:15Brad KingStatusbacklog => resolved
2013-11-02 14:15Brad KingResolutionopen => fixed
2013-11-02 14:15Brad KingFixed in Version => CMake 3.0
2013-11-02 14:15Brad KingTarget Version => CMake 3.0
2014-06-02 08:37Robert MaynardNote Added: 0035995
2014-06-02 08:37Robert MaynardStatusresolved => closed

Notes
(0033812)
David Cole   
2013-09-12 18:30   
See also the discussion in the notes in the related bug 0010158
(0033816)
Brad King   
2013-09-13 08:34   
The man page explains the VS version associated with each generator:

 http://www.cmake.org/cmake/help/v2.8.11/cmake.html#gen:VisualStudio11 [^]

The name in the GUI is currently the name of the generator as it will appear in the CMAKE_GENERATOR variable which projects test and expect to be stable across versions of CMake. Therefore we can't change the name of the generator outright.

However, we could look at adding aliases that show up in the GUI and are translated when seen in the -G command line option.
(0033819)
Cedric Perthuis   
2013-09-13 12:20   
Yes aliases would be nice. I think that most people won't read the man pages when they have a gui, it's assumed that the gui is self-explanatory.
Thanks for looking into this, I am sure it will prevent any confusion between versions.
(0034312)
Stephen Kelly   
2013-11-02 09:01   
Fixed by 29071fed2efbc7857f3994ac746641a4c5a36b9d ?
(0034336)
Brad King   
2013-11-02 14:15   
Yes, this is now fixed by

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=29071fed [^]

Instead of using an alias I went ahead and changed the generator name but made the generator factory know how to construct from either the old or new name. Any logic in CMake project code that uses CMAKE_GENERATOR already needs to match the generator name with and without the " <arch>" suffix so most cases should match the " <year> <arch>" suffix too. As this will be released along with a major version number bump we can be a little more aggressive with changes like this.
(0035995)
Robert Maynard   
2014-06-02 08:37   
Closing resolved issues that have not been updated in more than 4 months.