MantisBT - CDash
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014344CDash(No Category)public2013-08-07 12:492013-10-28 09:15
ReporterIgor 
Assigned ToJulien Jomier 
PrioritynoneSeveritytweakReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version2.2 
Summary0014344: [PATCH] Cosmetics: Simplify some if conditions
DescriptionUnset variables is a subset of empty variables:

 !isset($var) == true implies empty($var) == true
 !empty($var) == true implies isset($var) == true

Thus,

 !isset($var) || empty($var)

could be simplified to:

 empty($var)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Cosmetics-Simplify-some-if-conditions.patch (2,454) 2013-08-07 12:49
https://public.kitware.com/Bug/file/4839/0001-Cosmetics-Simplify-some-if-conditions.patch
Issue History
Date ModifiedUsernameFieldChange
2013-08-07 12:49IgorNew Issue
2013-08-07 12:49IgorFile Added: 0001-Cosmetics-Simplify-some-if-conditions.patch
2013-10-28 09:13Julien JomierAssigned To => Julien Jomier
2013-10-28 09:13Julien JomierStatusnew => assigned
2013-10-28 09:15Julien JomierStatusassigned => resolved
2013-10-28 09:15Julien JomierFixed in Version => 2.2
2013-10-28 09:15Julien JomierResolutionopen => fixed

There are no notes attached to this issue.