MantisBT - CMake |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0014165 | CMake | Modules | public | 2013-05-23 04:37 | 2013-11-04 09:33 |
|
Reporter | i94matjo | |
Assigned To | Stephen Kelly | |
Priority | normal | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | Win32 | OS | Windows | OS Version | XP |
Product Version | CMake 2.8.11 | |
Target Version | | Fixed in Version | | |
|
Summary | 0014165: FindQt4.cmake errors when using customized Qt |
Description | We are using a custom built Qt (with no Xml and No AxServer, it is actually a mix of QWS and Qt for windows). This causes FindQt4.cmake to crash.
I have fixed the problem by modifying our own FindQt4.cmake.
Since AxServer is not available you need to check QT_AXSERVER_FOUND before set_property is called on TARGET Qt4::QAxServer.
Also (we are using Qt 4.6.0) the Qt Svg library can be present without the Xml library (don't know if this is true for later Qt versions). Therefore we made a version check around "_qt4_add_target_private_depends(QtSvg Xml)". |
Steps To Reproduce | |
Additional Information | |
Tags | No tags attached. |
Relationships | |
Attached Files | 0001-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch (3,593) 2013-05-23 11:03 https://public.kitware.com/Bug/file/4766/0001-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch
0002-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch (3,583) 2013-05-24 02:17 https://public.kitware.com/Bug/file/4769/0002-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch |
|
Issue History |
Date Modified | Username | Field | Change |
2013-05-23 04:37 | i94matjo | New Issue | |
2013-05-23 08:30 | Brad King | Assigned To | => Stephen Kelly |
2013-05-23 08:30 | Brad King | Status | new => assigned |
2013-05-23 11:03 | Stephen Kelly | File Added: 0001-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch | |
2013-05-23 11:04 | Stephen Kelly | Note Added: 0033122 | |
2013-05-23 11:04 | Stephen Kelly | Status | assigned => feedback |
2013-05-24 02:17 | i94matjo | Note Added: 0033124 | |
2013-05-24 02:17 | i94matjo | Status | feedback => assigned |
2013-05-24 02:17 | i94matjo | File Added: 0002-FindQt4-Don-t-fail-if-certain-Qt-modules-are-unavail.patch | |
2013-05-24 04:43 | Stephen Kelly | Note Added: 0033125 | |
2013-05-24 04:43 | Stephen Kelly | Status | assigned => feedback |
2013-05-26 07:08 | i94matjo | Note Added: 0033132 | |
2013-05-26 07:08 | i94matjo | Status | feedback => assigned |
2013-05-27 02:27 | Stephen Kelly | Note Added: 0033133 | |
2013-06-03 10:20 | Stephen Kelly | Note Added: 0033204 | |
2013-06-03 10:20 | Stephen Kelly | Status | assigned => resolved |
2013-06-03 10:20 | Stephen Kelly | Resolution | open => fixed |
2013-11-04 09:33 | Robert Maynard | Note Added: 0034352 | |
2013-11-04 09:33 | Robert Maynard | Status | resolved => closed |
Notes |
|
(0033122)
|
Stephen Kelly
|
2013-05-23 11:04
|
|
Please try the attached patch.
As no one else has your setup to reproduce, it might be best if you extend the patch if you need more and re-upload. |
|
|
(0033124)
|
i94matjo
|
2013-05-24 02:17
|
|
We use a version in between 2.8.10.2 and 2.8.11 so I had to manually apply the patch. I had to do a small tweak though. I had to remove the "QAxServer" on the line "if(Q_WS_WIN) QAxServer". I modified the patch file with this little tweak. Otherwise it works perfectly. Thanks a lot! |
|
|
(0033125)
|
Stephen Kelly
|
2013-05-24 04:43
|
|
> I had to remove the "QAxServer" on the line "if(Q_WS_WIN) QAxServer". I modified the patch file with this little tweak.
Sorry, I don't know what line you are talking about. Can you clarify before I apply the patch?
Thanks, |
|
|
(0033132)
|
i94matjo
|
2013-05-26 07:08
|
|
Diff the original patch with my uploaded one and you'll see the line I'm talking about.
Thanks! |
|
|
(0033133)
|
Stephen Kelly
|
2013-05-27 02:27
|
|
|
|
(0033204)
|
Stephen Kelly
|
2013-06-03 10:20
|
|
Merged to master as b8af46cb878551cc5a1c9275f46792b282479ebb. |
|
|
(0034352)
|
Robert Maynard
|
2013-11-04 09:33
|
|
Closing resolved issues that have not been updated in more than 4 months. |
|