MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014110CMakeCTestpublic2013-04-24 07:422013-10-07 10:09
ReporterRolf Eike Beer 
Assigned ToRolf Eike Beer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.10.2 
Target VersionCMake 2.8.12Fixed in VersionCMake 2.8.12 
Summary0014110: Valgrind output should be collected via output file
DescriptionIf you have tests that have a result that depends on matching their output against a regular expressions those test will fail if valgrind reports any errors. Valgrind offers both --log-file as well as --log-fd. As e.g. Purify is already told to output it's finding to a file I guess it shouldn't be hard to do the same for valgrind (Source/CTest/cmCTestMemCheckHandler.cxx).

The question is if this could have any side effect, i.e. are there any valgrind versions that don't support that option? What happens on parallel test execution? Or is that already disabled for memcheck runs?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-04-24 07:42Rolf Eike BeerNew Issue
2013-05-04 12:52Rolf Eike BeerNote Added: 0032972
2013-05-04 12:52Rolf Eike BeerAssigned To => Rolf Eike Beer
2013-05-04 12:52Rolf Eike BeerStatusnew => assigned
2013-05-10 10:34Rolf Eike BeerNote Added: 0033025
2013-05-10 15:08Rolf Eike BeerStatusassigned => resolved
2013-05-10 15:08Rolf Eike BeerResolutionopen => fixed
2013-05-10 15:08Rolf Eike BeerFixed in Version => CMake 2.8.12
2013-05-10 15:08Rolf Eike BeerTarget Version => CMake 2.8.12
2013-10-07 10:09Robert MaynardNote Added: 0034046
2013-10-07 10:09Robert MaynardStatusresolved => closed

Notes
(0032972)
Rolf Eike Beer   
2013-05-04 12:52   
--log-file was introduced in valgrind 2.1.2, released in 2004. Before it was called --logfile, so if we really need to support something older we can even go further back. But for the moment I'll just assume that nobody will use a decade-old memchecker with a bleeding edge CMake and will just do the patch.
(0033025)
Rolf Eike Beer   
2013-05-10 10:34   
Merged to next, but may need some work because of other problems (like negative test times reported):

http://cmake.org/gitweb?p=cmake.git;a=commit;h=ae431450179eb5529790183893ea3870c9a95798 [^]
(0034046)
Robert Maynard   
2013-10-07 10:09   
Closing resolved issues that have not been updated in more than 4 months.