MantisBT - Bender
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013621BenderArmatures modulepublic2012-10-30 14:092013-02-14 14:44
ReporterJulien Finet 
Assigned Tojohan andruejol 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.1Fixed in Version0.1 
Summary0013621: Fix vtkBoneWidget errors
DescriptionThis is a placeholder for all the github comments
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0013671closed Julien Finet Task 1.1) Develop an application for specifying rigging for a voxelized anatomical model. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-30 14:09Julien FinetNew Issue
2012-10-30 14:09Julien FinetStatusnew => assigned
2012-10-30 14:09Julien FinetAssigned To => johan andruejol
2012-10-30 14:12Julien FinetNote Added: 0031352
2012-10-30 14:12Julien FinetNote Edited: 0031352bug_revision_view_page.php?bugnote_id=31352#r887
2012-10-30 14:14Julien FinetNote Edited: 0031352bug_revision_view_page.php?bugnote_id=31352#r888
2012-10-30 14:21Julien FinetNote Edited: 0031352bug_revision_view_page.php?bugnote_id=31352#r889
2012-10-31 15:26johan andruejolNote Added: 0031362
2012-10-31 16:51Julien FinetNote Edited: 0031352bug_revision_view_page.php?bugnote_id=31352#r890
2012-10-31 16:52Julien FinetNote Edited: 0031362bug_revision_view_page.php?bugnote_id=31362#r892
2012-10-31 16:53Julien FinetNote Edited: 0031362bug_revision_view_page.php?bugnote_id=31362#r893
2012-10-31 17:07johan andruejolNote Added: 0031365
2012-11-01 13:38Julien FinetNote Added: 0031370
2012-11-01 13:44Julien FinetNote Edited: 0031370bug_revision_view_page.php?bugnote_id=31370#r895
2012-11-01 14:27johan andruejolNote Added: 0031373
2012-11-01 14:48johan andruejolNote Added: 0031374
2012-11-01 14:54johan andruejolNote Edited: 0031374bug_revision_view_page.php?bugnote_id=31374#r897
2012-11-01 14:54johan andruejolStatusassigned => resolved
2012-11-01 14:54johan andruejolResolutionopen => fixed
2012-11-02 15:57johan andruejolNote Added: 0031389
2012-11-02 15:57johan andruejolStatusresolved => assigned
2012-11-02 17:13johan andruejolNote Added: 0031394
2012-11-02 17:13johan andruejolStatusassigned => resolved
2012-11-09 13:37Julien FinetRelationship addedchild of 0013671
2012-11-09 13:52Julien FinetTarget Version => 0.1
2013-01-17 17:53Julien FinetFixed in Version => 0.1
2013-02-14 14:38Julien FinetStatusresolved => closed
2013-02-14 14:44Julien FinetCategoryvtkBoneWidgets => Armatures module

Notes
(0031352)
Julien Finet   
2012-10-30 14:12   
(edited on: 2012-10-31 16:51)
a) SetWidgetState/ SetWidgetStateToRest/ SetWidgetStateToPose
https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2075349 [^]

b) Missing this-> prefix
https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2074442 [^]

c) Cleanup vtkArmatureWidget::AddBone
https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2074101 [^]

d) Display position takes 3 elements
https://github.com/vovythevov/Bender/commit/f2a35a8c31a65be4dc8a06abd66c297c279bd561#commitcomment-2075194 [^]

e) Register Bone in vtkArmatureWidget:
https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2075438 [^]
(0031362)
johan andruejol   
2012-10-31 15:26   
(edited on: 2012-10-31 16:53)
See the following commits:

a) SetWidgetState/ SetWidgetStateToRest/ SetWidgetStateToPose
https://github.com/vovythevov/Bender/commit/713e42a6b553081d52445f4413775c7022dab308 [^]
https://github.com/vovythevov/Bender/commit/f333249ad3bb60bc903cb50fce0b8216dba541fc [^]

f) Consistent method names:
https://github.com/vovythevov/Bender/commit/4290829b6759e84317c44d3e71c6894ff229f862 [^]
(0031365)
johan andruejol   
2012-10-31 17:07   
b) Missing this-> prefix
 && c) Cleanup vtkArmatureWidget::AddBone
 && e) Register Bone in vtkArmatureWidget
https://github.com/vovythevov/Bender/commit/41717cc579c0e999bcd63903e3d95ece5589a6fd [^]

d) Display position takes 3 elements
https://github.com/vovythevov/Bender/commit/4290829b6759e84317c44d3e71c6894ff229f862 [^]
(0031370)
Julien Finet   
2012-11-01 13:38   
(edited on: 2012-11-01 13:44)
g) AxesVisibility vs ShowParenthood
https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2088568 [^]

h) Distance utility function
https://github.com/vovythevov/Bender/commit/e145096205c91da629c1c375a9d2756964841c3e#commitcomment-2088607 [^]

i) Rename Distance into Length
The distance of a bone doesn't mean anything, its length does.
(0031373)
johan andruejol   
2012-11-01 14:27   
g) AxesVisibility vs ShowParenthood
https://github.com/vovythevov/Bender/commit/b770c79d211e1ec15da57ebd0da559f60d3eda9d [^]
(0031374)
johan andruejol   
2012-11-01 14:48   
(edited on: 2012-11-01 14:54)
h) Distance utility function
&& i) Rename Distance in Length
https://github.com/vovythevov/Bender/commit/2b678ba907af93cf57bfbd9199bd390bb2e55746 [^]
(0031389)
johan andruejol   
2012-11-02 15:57   
h) Distance utility function

The distance in the representation is only recomputed when the representation is
updated. This means that if the bone's representation exist but isn't displayed (and thus recomputed), the distance will never be updated.
(0031394)
johan andruejol   
2012-11-02 17:13   
h) Distance utility function

https://github.com/vovythevov/Bender/commit/cdb5c846998db55d0d1d0c7b5ebed802ad60c3b3 [^]