MantisBT - Bender
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013616BenderArmatures modulepublic2012-10-30 11:562013-04-02 14:28
ReporterJulien Finet 
Assigned Tojohan andruejol 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version1.0Fixed in Version0.1 
Summary0013616: Add more bone utility functions to vtkArmatureWidget
DescriptionThe following methods might be useful when manipulating bones:
 a) bool HasBone(vtkBoneWidget*);
 b) vtkBoneWidget* GetBoneParent(vtkBoneWidget* child);
 c) vtkCollection* FindBoneChildren(vtkBoneWidget* parent);
 d) void ReparentBone(vtkBoneWidget* bone, vtkBoneWidget* newParent);
 e) void MergeBones(vtkBoneWidget* bone1, vtkBoneWidget* bone);
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0013671closed Julien Finet Task 1.1) Develop an application for specifying rigging for a voxelized anatomical model. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-30 11:56Julien FinetNew Issue
2012-10-30 11:56Julien FinetStatusnew => assigned
2012-10-30 11:56Julien FinetAssigned To => johan andruejol
2012-10-31 15:22johan andruejolNote Added: 0031361
2012-11-06 13:26johan andruejolNote Added: 0031474
2012-11-09 13:36Julien FinetRelationship addedchild of 0013671
2012-11-09 17:22Julien FinetDescription Updatedbug_revision_view_page.php?rev_id=901#r901
2012-11-13 12:02johan andruejolNote Added: 0031541
2012-11-13 15:33johan andruejolNote Added: 0031542
2012-11-13 16:21johan andruejolNote Added: 0031545
2012-11-14 09:38johan andruejolNote Added: 0031555
2012-11-26 11:36johan andruejolNote Added: 0031709
2012-11-26 11:56Julien FinetNote Added: 0031711
2012-11-26 12:36johan andruejolNote Added: 0031712
2012-11-26 14:30Julien FinetNote Added: 0031714
2012-11-26 14:31johan andruejolNote Added: 0031715
2012-11-26 14:33johan andruejolNote Added: 0031716
2012-11-26 16:12johan andruejolNote Deleted: 0031716
2012-11-26 16:12johan andruejolNote Deleted: 0031715
2012-11-26 16:23johan andruejolNote Added: 0031719
2012-11-26 16:23johan andruejolStatusassigned => resolved
2012-11-26 16:23johan andruejolResolutionopen => fixed
2012-11-29 15:51johan andruejolStatusresolved => feedback
2012-11-29 15:51johan andruejolResolutionfixed => reopened
2012-11-29 15:52johan andruejolNote Added: 0031769
2012-11-29 15:52johan andruejolStatusfeedback => resolved
2012-11-29 15:52johan andruejolResolutionreopened => fixed
2013-01-17 17:53Julien FinetFixed in Version => 0.1
2013-02-14 14:38Julien FinetStatusresolved => closed
2013-02-14 14:44Julien FinetCategoryvtkBoneWidgets => Armatures module
2013-04-02 14:28Julien FinetTarget Version => 1.0

Notes
(0031361)
johan andruejol   
2012-10-31 15:22   
Part of it solved with:

https://github.com/vovythevov/Bender/commit/41717cc579c0e999bcd63903e3d95ece5589a6fd [^]
(0031474)
johan andruejol   
2012-11-06 13:26   
It would also be nice to have signals after adding/removing a bone.
(0031541)
johan andruejol   
2012-11-13 12:02   
d) ReparentBones(..):
https://github.com/vovythevov/Bender/commit/ea2efa289805a6e42c9f838b24b59f9cd08f1afa [^]

f)Events:

https://github.com/vovythevov/Bender/commit/93e3f1b6cba352e28fc4881d62d880bb2bc50973 [^]
(0031542)
johan andruejol   
2012-11-13 15:33   
d) ReparentBones(...)

https://github.com/vovythevov/Bender/commit/4c4fba4988d612d7d53504bf66600f4f28b19034 [^]
(0031545)
johan andruejol   
2012-11-13 16:21   
g) Add AlwaysOnTop Property
(0031555)
johan andruejol   
2012-11-14 09:38   
g) Add AlwaysOnTop Property

https://github.com/vovythevov/Bender/commit/1471531d9105967bf4984460a9ada0b8c46b7d74 [^]
(0031709)
johan andruejol   
2012-11-26 11:36   
h)
BoneHasDirectParent(vtkBoneWidget* bone, vtkBoneWidget* parent)
BoneHasParent(vtkBoneWidget* bone, vtkBoneWidget* parent)
(0031711)
Julien Finet   
2012-11-26 11:56   
h) rename to: IsParent(...), IsDirectParent(...) ?
(0031712)
johan andruejol   
2012-11-26 12:36   
H) Well you apply it to the armature, so for me it was better to have:
  armature->BoneHasParent(bone, parent);
rather than:
  armature->IsParent(bone, parent);
But it's really a matter of personal opinion. What do you recommend ?
(0031714)
Julien Finet   
2012-11-26 14:30   
Then I guess I would be fine with IsBoneParent()/IsBoneDirectParent().
"Is" is more "VTK" style I believe. Anyway, it's not a big issue.
(0031719)
johan andruejol   
2012-11-26 16:23   
h)IsBoneParent
https://github.com/vovythevov/Bender/commit/645c5c68252ba21820a9e6d36c6654a6701c5a24 [^]
https://github.com/vovythevov/Bender/commit/940003c07f353d882bbd2297a1558a11e72c08ea [^]

e)MergeBones
https://github.com/vovythevov/Bender/commit/769f1b6adfcedde8d1fcc939cb7cb10f36429686 [^]
(0031769)
johan andruejol   
2012-11-29 15:52   
d)Fix ReparentBones():
https://github.com/vovythevov/Bender/commit/90c53ec28227dd3826a9895e76dc949370f37b19 [^]

e) Fix MergeBones():
https://github.com/vovythevov/Bender/commit/0e22abde5fc374e80fdfb47aff35d9ec546b8eb2 [^]