MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013578CMakeCPackpublic2012-10-08 15:312013-03-04 08:38
ReporterAlexander 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86-64OSWindowsOS Version7
Product VersionCMake 2.8.9 
Target VersionCMake 2.8.10Fixed in VersionCMake 2.8.10 
Summary0013578: NSIS template incorrectly uses CPACK_PACKAGE_NAME instead of CPACK_PACKAGE_INSTALL_REGISTRY_KEY
DescriptionOn line 905 of NSIS.template.in there is this code:

ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_NAME@" "UninstallString"

@CPACK_PACKAGE_NAME@ should read @CPACK_PACKAGE_INSTALL_REGISTRY_KEY@, since that's what's used across the rest of the file, e.g. on line 77:

ReadRegDWORD $AR_RegFlags HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@\Components\${SecName}" "Installed"

Because of this bug the CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL option doesn't really work.

Thanks,
Alexander
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0013455closed David Cole CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL is broken 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-08 15:31AlexanderNew Issue
2012-10-15 09:59David ColeAssigned To => David Cole
2012-10-15 09:59David ColeStatusnew => assigned
2012-10-16 08:01David ColeNote Added: 0031243
2012-10-16 08:01David ColeStatusassigned => resolved
2012-10-16 08:01David ColeResolutionopen => fixed
2012-10-16 08:02David ColeNote Added: 0031244
2012-10-16 08:50David ColeNote Deleted: 0031244
2012-10-17 16:59David ColeFixed in Version => CMake 2.8.10
2012-10-17 16:59David ColeTarget Version => CMake 2.8.10
2012-10-25 12:51David ColeRelationship addedrelated to 0013455
2013-03-04 08:38Robert MaynardNote Added: 0032489
2013-03-04 08:38Robert MaynardStatusresolved => closed

Notes
(0031243)
David Cole   
2012-10-16 08:01   
Fix merged to 'next':

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=12c092cf67b39e8519b3672afad05fdc5d8f1d5c [^]

Not sure yet if this will go in 2.8.10 or 2.8.11. I'll mark it accordingly after that's discussed and decided.
(0032489)
Robert Maynard   
2013-03-04 08:38   
Closing resolved issues that have not been updated in more than 4 months.