MantisBT - CMake
View Issue Details
0013525CMake(No Category)public2012-09-10 15:152016-06-10 14:31
danoushh 
Kitware Robot 
normaltweakN/A
closedmoved 
allWindowsALL
CMake 2.8.9 
 
0013525: Add silent flag to NSIS auto uninstall require
In issue ID 0009946 the CPACK NSIS template was modified with the CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL flag. This is great but it would be nice to also have an optional flag that performs the uninstall silently.

In CPACK using NSIS generator set CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL to ON
No tags attached.
? NSIS.template.in (29,649) 2014-04-24 15:20
https://public.kitware.com/Bug/file/5138/NSIS.template.in
? NSIS.template.in.2 (29,649) 2014-04-25 10:30
https://public.kitware.com/Bug/file/5139/NSIS.template.in.2
Issue History
2012-09-10 15:15danoushhNew Issue
2012-09-10 16:00danoushhNote Added: 0030987
2014-04-24 15:20danoushhFile Added: NSIS.template.in
2014-04-24 15:23danoushhNote Added: 0035774
2014-04-24 15:24danoushhNote Edited: 0035774bug_revision_view_page.php?bugnote_id=35774#r1453
2014-04-24 15:29danoushhNote Added: 0035775
2014-04-25 10:30danoushhFile Added: NSIS.template.in.2
2016-06-10 14:28Kitware RobotNote Added: 0042118
2016-06-10 14:28Kitware RobotStatusnew => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:28Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0030987)
danoushh   
2012-09-10 16:00   
A silent uninstall should only be performed immediately before the new installation begin - i.e. after the user has accepted the terms, had a change to go through the wizard and clicked the "install" button.
(0035774)
danoushh   
2014-04-24 15:23   
(edited on: 2014-04-24 15:24)
Added a small patch for silent uninstall in NSIS.template.in

The patch works by checking for:
CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL_SILENTLY

When CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL_SILENTLY is "ON", NSIS silent uninstall is performed and UI dialogs are not shown.


TODO:
 - ensure that uninstall is not performed until the user has accepted all terms and proceeded to install the new package

(0035775)
danoushh   
2014-04-24 15:29   
Update NSIS.tempalte.in.2 so that CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL_SILENTLY works independent of CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL
(0042118)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.