MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013272CMakeCMakepublic2012-06-05 16:032012-11-05 14:33
ReporterDaniel Richard G. 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformPowerPCOSAIXOS Version5.3
Product VersionCMake 2.8.8 
Target VersionCMake 2.8.9Fixed in VersionCMake 2.8.9 
Summary0013272: Use of [o]stringstream instead of strstream breaks the build on older systems
DescriptionMost CMake code uses strstream when stringstream is not available. However, the following files in the git nightly branch currently do not:

    Source/cmQtAutomoc.cxx
    Source/cmGlobalNinjaGenerator.cxx
    Source/cmLocalNinjaGenerator.cxx
    Source/cmNinjaTargetGenerator.cxx
    Source/cmNinjaNormalTargetGenerator.cxx

The build failures may be reviewed at

    http://open.cdash.org/viewBuildError.php?buildid=2336790 [^]
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-05 16:03Daniel Richard G.New Issue
2012-06-05 16:13Brad KingAssigned To => Peter Collingbourne
2012-06-05 16:13Brad KingStatusnew => assigned
2012-06-05 16:16Brad KingNote Added: 0029616
2012-06-06 15:14Brad KingAssigned ToPeter Collingbourne => Brad King
2012-06-06 15:30Brad KingNote Added: 0029622
2012-06-06 15:30Brad KingStatusassigned => resolved
2012-06-06 15:30Brad KingResolutionopen => fixed
2012-06-06 15:30Brad KingFixed in Version => CMake 2.8.9
2012-06-06 15:30Brad KingTarget Version => CMake 2.8.9
2012-06-07 14:48Daniel Richard G.Note Added: 0029633
2012-06-07 14:48Daniel Richard G.Statusresolved => feedback
2012-06-07 14:48Daniel Richard G.Resolutionfixed => reopened
2012-06-07 15:17Brad KingNote Added: 0029636
2012-06-07 15:17Brad KingStatusfeedback => resolved
2012-06-07 15:17Brad KingResolutionreopened => fixed
2012-06-12 15:58Brad KingNote Added: 0029669
2012-06-12 18:48Daniel Richard G.Note Added: 0029674
2012-06-12 18:48Daniel Richard G.Statusresolved => feedback
2012-06-12 18:48Daniel Richard G.Resolutionfixed => reopened
2012-06-14 08:05Brad KingNote Added: 0029692
2012-06-14 08:05Brad KingStatusfeedback => resolved
2012-06-14 08:05Brad KingResolutionreopened => fixed
2012-11-05 14:33David ColeNote Added: 0031452
2012-11-05 14:33David ColeStatusresolved => closed

Notes
(0029616)
Brad King   
2012-06-05 16:16   
Uses of "std::ostringstream" and "std::stringstream" should be converted to "cmsys_ios::ostringstream" and "cmsys_ios::stringstream" which provide compatibility. Many places also use the older cmOStringStream wrapper.
(0029622)
Brad King   
2012-06-06 15:30   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a6a3364a [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=59205921 [^]
(0029633)
Daniel Richard G.   
2012-06-07 14:48   
Looks like some tweaking is still needed in cmQtAutomoc.cxx:

.../CMake/Source/cmQtAutomoc.cxx: In method `bool cmQtAutomoc::RunAutomoc ()':
.../CMake/Source/cmQtAutomoc.cxx:553: no matching function for call to `cmsys_ios::stringstream::stringstream (ios::open_mode)'
.../CMake-build/Source/cmsys/ios/sstream:87: candidates are: cmsys_ios::stringstream::stringstream ()
.../CMake-build/Source/cmsys/ios/sstream:88: cmsys_ios::stringstream::stringstream (const string &)
.../CMake-build/Source/cmsys/ios/sstream:110: cmsys_ios::stringstream::stringstream (const cmsys_ios::stringstream &)

(from http://open.cdash.org/viewBuildError.php?buildid=2341944 [^])
(0029636)
Brad King   
2012-06-07 15:17   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2116e231 [^]
(0029669)
Brad King   
2012-06-12 15:58   
Re 0013272:0029636: I squashed that into the original fix:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=94de9829 [^]

in preparation for merge to master.
(0029674)
Daniel Richard G.   
2012-06-12 18:48   
A bit more follow-up seems needed on AIX:

    http://open.cdash.org/viewBuildError.php?buildid=2355782 [^]
(0029692)
Brad King   
2012-06-14 08:05   
This commit removed the offending lines:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4b43999c [^]
(0031452)
David Cole   
2012-11-05 14:33   
Closing resolved issues that have not been updated in more than 4 months.