MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013214CMakeCMakepublic2012-05-11 10:322012-10-01 13:22
ReporterJan Schaffmeister 
Assigned ToBrad King 
PriorityurgentSeverityblockReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformMacOSiOSOS Version5.1
Product VersionCMake 2.8.8 
Target VersionCMake 2.8.9Fixed in VersionCMake 2.8.9 
Summary0013214: Storyboards do not get recognized correctly
DescriptionOn iOS using Xcode *.storyboard files do not get compiled correctly. Even with a PRE_BUILD add_custom_command build step, one gets errors that complained about modified signed resources.

Here is a valid fix for cmake:
in cmGlobalXCodeGenerator.cxx there should be:


std::string
GetSourcecodeValueFromFileExtension(const std::string& _ext,
                                    const std::string& lang)
{
  std::string ext = cmSystemTools::LowerCase(_ext);
  std::string sourcecode = "sourcecode";

  if(ext == "o")
    {
    sourcecode = "compiled.mach-o.objfile";
    }
  else if(ext == "xib")
    {
    sourcecode = "file.xib";
    }
  else if(ext == "storyboard")
    {
    sourcecode = "file.storyboard";
    }
  else if(ext == "mm")
    {
    sourcecode += ".cpp.objcpp";
    }
  else if(ext == "m")
    {
    sourcecode += ".c.objc";
    }
  else if(ext == "xib")
    {
    sourcecode += ".file.xib";
    }
  else if(ext == "plist")
    {
    sourcecode += ".text.plist";
    }
  else if(ext == "h")
    {
    sourcecode += ".c.h";
    }
  else if(ext == "hxx" || ext == "hpp" || ext == "txx"
    || ext == "pch" || ext == "hh")
    {
    sourcecode += ".cpp.h";
    }
  else if(ext == "png" || ext == "gif" || ext == "jpg")
    {
    sourcecode = "image";
    }
  else if(ext == "txt")
    {
    sourcecode += ".text";
    }
  else if(lang == "CXX")
    {
    sourcecode += ".cpp.cpp";
    }
  else if(lang == "C")
    {
    sourcecode += ".c.c";
    }
  else if(lang == "Fortran")
    {
    sourcecode += ".fortran.f90";
    }
  //else
  // {
  // // Already specialized above or we leave sourcecode == "sourcecode"
  // // which is probably the most correct choice. Extensionless headers,
  // // for example... Or file types unknown to Xcode that do not map to a
  // // valid lastKnownFileType value.
  // }

  return sourcecode;
}
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-11 10:32Jan SchaffmeisterNew Issue
2012-05-14 14:57Brad KingNote Added: 0029469
2012-05-14 14:57Brad KingAssigned To => Brad King
2012-05-14 14:57Brad KingStatusnew => resolved
2012-05-14 14:57Brad KingResolutionopen => fixed
2012-05-14 14:57Brad KingFixed in Version => CMake 2.8.9
2012-05-14 14:57Brad KingTarget Version => CMake 2.8.9
2012-10-01 13:22David ColeNote Added: 0031127
2012-10-01 13:22David ColeStatusresolved => closed

Notes
(0029469)
Brad King   
2012-05-14 14:57   
Applied, thanks:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d59ba0c5 [^]
(0031127)
David Cole   
2012-10-01 13:22   
Closing resolved issues that have not been updated in more than 4 months.