MantisBT - CMake | ||||||||||
View Issue Details | ||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||||
0013202 | CMake | CPack | public | 2012-05-08 14:52 | 2013-04-17 08:54 | |||||
Reporter | David Golub | |||||||||
Assigned To | David Cole | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | |||||
Status | closed | Resolution | fixed | |||||||
Platform | Intel x64 | OS | Microsoft Windows | OS Version | Windows 7 | |||||
Product Version | CMake 2.8.8 | |||||||||
Target Version | CMake 2.8.11 | Fixed in Version | CMake 2.8.11 | |||||||
Summary | 0013202: CPack fails with latest prerelease NSIS | |||||||||
Description | There have been some changes to NSIS that break compatibility with CPack since the latest NSIS release. There is now a standard library function called RemoveSection, which conflicts with the function with the same name in CPack-generated NSIS scripts. Also, NSIS scripts must now explicitly specify that they require administrator access. Therefore, CPack-generated installers will give an error that they require elevation unless the user explicitly runs them as administrator. I'd like to submit a patch to resolve these issues: diff --git a/Modules/NSIS.template.in b/Modules/NSIS.template.in --- a/Modules/NSIS.template.in +++ b/Modules/NSIS.template.in @@ -37,6 +37,9 @@ ;Set compression SetCompressor @CPACK_NSIS_COMPRESSOR@ + ;Require administrator access + RequestExecutionLevel admin + @CPACK_NSIS_DEFINES@ !include Sections.nsh @@ -119,7 +122,7 @@ "exit_${SecName}:" !macroend -!macro RemoveSection SecName +!macro RemoveSection_CPack SecName ; This macro is used to call section's Remove_... macro ;from the uninstaller. ;Input: section index constant name specified in Section command. @@ -841,7 +844,7 @@ DeleteRegKey SHCTX "Software\@CPACK_PACKAGE_VENDOR@\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@" ; Removes all optional components - !insertmacro SectionList "RemoveSection" + !insertmacro SectionList "RemoveSection_CPack" !insertmacro MUI_STARTMENU_GETFOLDER Application $MUI_TEMP | |||||||||
Steps To Reproduce | Download the latest NSIS source code from the NSIS Subversion repository. Build an installer for NSIS and install it. CPack will now fail to build NSIS packages. | |||||||||
Additional Information | Please note that there is an unrelated bug in NSIS itself that will also cause CPack to fail. To fix this bug, edit Contrib\Language files\SimpChinese.nsh, changing the line !insertmacro LANGFILE "SimpChinese" "Chinese (Simplified)" to !insertmacro LANGFILE "SimpChinese" "Chinese (Simplified)" "Chinese (Simplified)" and similarly modifying the analogous line in TradChinese.nsh. This fix has already been reported to NSIS. | |||||||||
Tags | No tags attached. | |||||||||
Relationships |
| |||||||||
Attached Files | ![]() https://public.kitware.com/Bug/file/4324/0001-CPack-NSIS-Fix-compatibility-issues-with-prerelease-.patch | |||||||||
Issue History | ||||||||||
Date Modified | Username | Field | Change | |||||||
2012-05-08 14:52 | David Golub | New Issue | ||||||||
2012-05-08 15:01 | David Cole | Note Added: 0029422 | ||||||||
2012-05-08 16:35 | David Golub | Note Added: 0029423 | ||||||||
2012-05-08 16:48 | Eric NOULARD | Relationship added | parent of 0013203 | |||||||
2012-05-08 16:48 | Eric NOULARD | Relationship replaced | related to 0013203 | |||||||
2012-05-08 16:54 | David Cole | Note Added: 0029424 | ||||||||
2012-05-08 16:55 | David Cole | Note Edited: 0029424 | bug_revision_view_page.php?bugnote_id=29424#r643 | |||||||
2012-05-08 17:02 | David Cole | Note Added: 0029425 | ||||||||
2012-05-08 17:02 | David Golub | Note Added: 0029426 | ||||||||
2012-05-09 15:38 | David Golub | File Added: 0001-CPack-NSIS-Fix-compatibility-issues-with-prerelease-.patch | ||||||||
2012-05-09 15:38 | David Golub | Note Added: 0029459 | ||||||||
2012-06-20 18:34 | David Cole | Assigned To | => David Cole | |||||||
2012-06-20 18:34 | David Cole | Status | new => assigned | |||||||
2012-08-14 19:12 | David Cole | Target Version | => CMake 2.8.10 | |||||||
2012-09-20 17:18 | David Cole | Note Added: 0031073 | ||||||||
2012-10-01 15:20 | David Cole | Note Added: 0031142 | ||||||||
2012-10-01 15:20 | David Cole | Target Version | CMake 2.8.10 => CMake 2.8.11 | |||||||
2012-11-20 16:56 | David Cole | Note Added: 0031633 | ||||||||
2012-11-20 16:56 | David Cole | Status | assigned => resolved | |||||||
2012-11-20 16:56 | David Cole | Fixed in Version | => CMake 2.8.11 | |||||||
2012-11-20 16:56 | David Cole | Resolution | open => fixed | |||||||
2013-04-17 08:54 | Robert Maynard | Note Added: 0032873 | ||||||||
2013-04-17 08:54 | Robert Maynard | Status | resolved => closed |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|