MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013092CMakeCMakepublic2012-04-01 20:132012-09-03 16:00
ReporterChristoph Anton Mitterer 
Assigned ToBrad King 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionsuspended 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0013092: change set() behaviour when value is inset, to define the variable as true
DescriptionHi.

To me it seems a bit inconsistent that:
set(FOO)
unsets FOO.

Given that you interpret a unset variable as false and given that unset() is the opposite of set(), it would IMHO make more sense to set FOO to true.
This would also be more consistent with C/C++ preprocessor's understanding of true/false.

And after all, that a command called "set" unsets is a bit awkward.


Of course this will break things, but given your nice policy mechanism this shouldn't really harm.

Cheers,
Chris.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-01 20:13Christoph Anton MittererNew Issue
2012-04-09 09:03Brad KingNote Added: 0029095
2012-04-09 09:03Brad KingStatusnew => resolved
2012-04-09 09:03Brad KingResolutionopen => suspended
2012-04-09 09:03Brad KingAssigned To => Brad King
2012-09-03 16:00David ColeNote Added: 0030845
2012-09-03 16:00David ColeStatusresolved => closed

Notes
(0029095)
Brad King   
2012-04-09 09:03   
Issues 0013083, 0013089, 0013090, 0013091, 0013092, 0013109, and 0013111 are all interesting suggestions but the issue tracker is not a good place to discuss them. The user list is a better place for discussion because it may attract interest from others, and in particular from potential contributors. Others may also suggest alternative solutions.
(0030845)
David Cole   
2012-09-03 16:00   
Closing resolved issues that have not been updated in more than 4 months.