MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013066CMakeModulespublic2012-03-26 06:102012-09-03 16:01
ReporterKashif Rasul 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.8Fixed in VersionCMake 2.8.8 
Summary0013066: Use OSX_DEVELOPER_ROOT in Platform/Darwin.cmake
DescriptionThe /Developer directory is being deprecated so use the ${OSX_DEVELOPER_ROOT} instead.

I also added "/usr/local" for Homebrew to CMAKE_SYSTEM_PREFIX_PATH.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0012621closed David Cole Compatibility with Xcode 4.3 
Attached Filespatch darwin.patch (511) 2012-03-26 06:10
https://public.kitware.com/Bug/file/4266/darwin.patch
Issue History
Date ModifiedUsernameFieldChange
2012-03-26 06:10Kashif RasulNew Issue
2012-03-26 06:10Kashif RasulFile Added: darwin.patch
2012-03-26 09:20Brad KingRelationship addedrelated to 0012621
2012-03-26 09:46Brad KingNote Added: 0028970
2012-03-26 09:46Brad KingStatusnew => resolved
2012-03-26 09:46Brad KingResolutionopen => fixed
2012-03-26 09:46Brad KingAssigned To => Brad King
2012-03-27 14:56David ColeNote Added: 0028982
2012-03-27 14:56David ColeStatusresolved => feedback
2012-03-27 14:56David ColeResolutionfixed => reopened
2012-03-27 15:13Brad KingAssigned ToBrad King => David Cole
2012-03-27 15:13Brad KingStatusfeedback => assigned
2012-04-06 11:28David ColeNote Added: 0029090
2012-04-10 15:26David ColeFixed in Version => CMake 2.8.8
2012-04-10 15:26David ColeTarget Version => CMake 2.8.8
2012-04-18 13:03David ColeStatusassigned => resolved
2012-04-18 13:03David ColeResolutionreopened => fixed
2012-09-03 16:01David ColeNote Added: 0030854
2012-09-03 16:01David ColeStatusresolved => closed

Notes
(0028970)
Brad King   
2012-03-26 09:46   
Thanks. I applied the OSX_DEVELOPER_ROOT hunk from the patch:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=98b9a7f6 [^]

Platform/UnixPaths already adds /usr/local as the first path in CMAKE_SYSTEM_PREFIX_PATH so the latter hunk should not be needed.
(0028982)
David Cole   
2012-03-27 14:56   
Except...

On a machine with Xcode 4.3 installed, there is no "Applications" folder inside Developer anymore:

$ ls /Applications/Xcode.app/Contents/Developer/
Documentation Library Platforms Tools
Headers Makefiles Toolchains usr

...but there is one as a sibling of Developer:

$ ls /Applications/Xcode.app/Contents/
Applications Frameworks MacOS PlugIns _CodeSignature
CodeResources Info.plist OtherFrameworks Resources _MASReceipt
Developer Library PkgInfo SharedFrameworks version.plist

So that's the one that should be searched, and it is not under OSX_DEVELOPER_ROOT. I'm afraid the patch should use the Developer root variable if there is an Applications folder in there, but use the sibling if it exists...
(0029090)
David Cole   
2012-04-06 11:28   
Added this commit to address my concerns raised in the previous note:

  http://public.kitware.com/gitweb?p=cmake.git;a=commitdiff;h=d9edf46760a39d230836a7b99fb4ac33d466c337 [^]
(0030854)
David Cole   
2012-09-03 16:01   
Closing resolved issues that have not been updated in more than 4 months.