MantisBT - CMake
View Issue Details
0013018CMakeCMakepublic2012-03-05 19:502012-04-19 15:52
Stephen Kelly 
Alex Neundorf 
normalminoralways
closedfixed 
 
CMake 2.8.8CMake 2.8.8 
0013018: QtAutoMoc does not expand add_definitions arguments consistently
If the argument to add_definitions() is quoted oddly, CMake handles it correctly, but the automoc feature does not.

The line this->GenerateAll = true; is hit to generate all targets again.

In the attached file, each invocation of 'make' causes a full rebuild.
No tags attached.
gz add_definitions.tar.gz (607) 2012-03-05 19:50
https://public.kitware.com/Bug/file/4249/add_definitions.tar.gz
Issue History
2012-03-05 19:50Stephen KellyNew Issue
2012-03-05 19:50Stephen KellyFile Added: add_definitions.tar.gz
2012-03-06 13:38Alex NeundorfAssigned To => Alex Neundorf
2012-03-06 13:38Alex NeundorfStatusnew => assigned
2012-03-20 17:54Alex NeundorfNote Added: 0028948
2012-03-20 18:52Stephen KellyNote Added: 0028949
2012-03-28 15:43Alex NeundorfNote Added: 0028993
2012-03-28 15:43Alex NeundorfStatusassigned => closed
2012-03-28 15:43Alex NeundorfResolutionopen => fixed
2012-04-19 15:52David ColeFixed in Version => CMake 2.8.8
2012-04-19 15:52David ColeTarget Version => CMake 2.8.8

Notes
(0028948)
Alex Neundorf   
2012-03-20 17:54   
Please give the AutomocProperCMakeEscaping-13018 branch on stage a try, this should fix it.
I haven't added a test yet.
(0028949)
Stephen Kelly   
2012-03-20 18:52   
I can confirm that this fixes the issue in solid. I reverted https://projects.kde.org/projects/kde/kdelibs/repository/revisions/56fbb4468c5c8ac0bee4490ecefd9b7d6f875aeb/diff/tier1/solid/autotests/CMakeLists.txt [^] to test it.

Thanks,
(0028993)
Alex Neundorf   
2012-03-28 15:43   
Merged into master, fix confirmed by reporter.