MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012625CMakeModulespublic2011-12-13 13:372012-05-09 15:26
Reportertgallagher 
Assigned ToDavid Cole 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinux 64bitOSOpenSuSEOS Version12.1
Product VersionCMake 2.8.6 
Target VersionCMake 2.8.7Fixed in VersionCMake 2.8.7 
Summary0012625: FindLAPACK does not find pthreads with MKL
DescriptionWhen trying to use FindLAPACK with Intel MKL, it does not include the pthreads library in the libraries required despite the find_package(Threads).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch findLAPACK-Master.patch (761) 2011-12-13 13:38
https://public.kitware.com/Bug/file/4144/findLAPACK-Master.patch
patch findLAPACK-Release.patch (761) 2011-12-13 13:38
https://public.kitware.com/Bug/file/4145/findLAPACK-Release.patch
Issue History
Date ModifiedUsernameFieldChange
2011-12-13 13:37tgallagherNew Issue
2011-12-13 13:38tgallagherNote Added: 0027957
2011-12-13 13:38tgallagherFile Added: findLAPACK-Master.patch
2011-12-13 13:38tgallagherFile Added: findLAPACK-Release.patch
2011-12-13 16:19David ColeAssigned To => David Cole
2011-12-13 16:19David ColeStatusnew => assigned
2011-12-13 16:20David ColeNote Added: 0027959
2011-12-13 16:23tgallagherNote Added: 0027960
2011-12-13 16:33David ColeNote Added: 0027961
2011-12-13 19:16David ColeTarget Version => CMake 2.8.7
2011-12-13 19:17David ColeNote Added: 0027962
2011-12-16 10:12David ColeStatusassigned => resolved
2011-12-16 10:12David ColeFixed in Version => CMake 2.8.7
2011-12-16 10:12David ColeResolutionopen => fixed
2012-05-09 15:26David ColeNote Added: 0029441
2012-05-09 15:26David ColeStatusresolved => closed

Notes
(0027957)
tgallagher   
2011-12-13 13:38   
When testing that the libraries works, it links against the threads library, but then when returning the libraries needed, the threads library is not included in the list.

I've uploaded patches to fix this on both release (2.8.6) and master.
(0027959)
David Cole   
2011-12-13 16:20   
FYI: when posting patches, you only need to post patches against 'master' - our workflow bases all new work on master and merges work in to other branches after that as needed.
(0027960)
tgallagher   
2011-12-13 16:23   
Not a problem, I was going off of:

http://www.cmake.org/Wiki/CMake/Git/Develop [^]

Which under the "Create a Topic" section says to go off of origin/release if it is a bug in the latest release.
(0027961)
David Cole   
2011-12-13 16:33   
No problem -- that comment about building off of "origin/release" would be if we were going to build a new patch release (in this case, something like a 2.8.6.1 just to include this bug fix)...

If you submit patches on origin/master, that's good enough for most cases. If it's hard to cherry-pick or otherwise get onto release and we need to, we'll ask for you help then.

Thanks!
(0027962)
David Cole   
2011-12-13 19:17   
Fix pushed to 'next' today:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b3c42cb0123c7d21b6a23b1b7517cbb27d55df76 [^]
(0029441)
David Cole   
2012-05-09 15:26   
Closing resolved issues that have not been updated in more than 4 months.