MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012441CMakeCMakepublic2011-09-01 23:352012-07-09 06:52
Reportervastevaste 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 2.8.7Fixed in VersionCMake 2.8.7 
Summary0012441: No progress reporting for add_custom_command
DescriptionProgress reporting doesn't seem to work for individual rules added by add_custom_commands. Progress isn't updated until the add_custom_target-target is built.

Is this intentional?

I get this:

$ make
[ 0%] Generating test1.txt
[ 0%] Generating test2.txt
[ 0%] Generating test3.txt
[ 0%] Generating test4.txt
[ 0%] Generating test5.txt
[ 0%] Generating test6.txt
[100%] Built target test

But I expected this:

$ echo include CMakeFiles/test.dir/progress.make >> CMakeFiles/test.dir/build.make
$ make clean && make
[ 16%] Generating test1.txt
[ 33%] Generating test2.txt
[ 50%] Generating test3.txt
[ 66%] Generating test4.txt
[ 83%] Generating test5.txt
[100%] Generating test6.txt
[100%] Built target test
Steps To Reproduce
Additional InformationThe generated build file looks like this:

test1.txt:
        $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_1)
        @$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --blue --bold "Generating test1.txt"
        touch test1.txt

But VERBOSE=1 shows this (without $(CMAKE_PROGRESS_1)):

/home/vaste/src/cmake-2.8.5/build/bin/cmake -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles
[ 0%] Generating test1.txt
touch test1.txt

If I manually include progress.make in build.make it seems to work. Like this:

$ echo include CMakeFiles/test.dir/progress.make >> CMakeFiles/test.dir/build.make
$ make clean && make
TagsNo tags attached.
Relationships
Attached Filestxt CMakeLists.txt (423) 2011-09-01 23:35
https://public.kitware.com/Bug/file/4042/CMakeLists.txt
patch fix_custom_target_progress.patch (1,682) 2011-09-13 05:51
https://public.kitware.com/Bug/file/4051/fix_custom_target_progress.patch
Issue History
Date ModifiedUsernameFieldChange
2011-09-01 23:35vastevasteNew Issue
2011-09-01 23:35vastevasteFile Added: CMakeLists.txt
2011-09-01 23:38vastevasteNote Added: 0027318
2011-09-01 23:38vastevasteNote Added: 0027319
2011-09-01 23:39vastevasteNote Edited: 0027318bug_revision_view_page.php?bugnote_id=27318#r412
2011-09-01 23:39vastevasteNote Deleted: 0027319
2011-09-12 23:13vastevasteNote Added: 0027411
2011-09-13 05:51vastevasteFile Added: fix_custom_target_progress.patch
2011-09-13 05:53vastevasteNote Added: 0027413
2011-10-28 12:25David ColeTarget Version => CMake 2.8.7
2011-12-13 19:38David ColeAssigned To => David Cole
2011-12-13 19:38David ColeStatusnew => assigned
2011-12-13 20:34David ColeNote Added: 0027980
2011-12-13 20:34David ColeStatusassigned => resolved
2011-12-13 20:34David ColeResolutionopen => fixed
2011-12-16 17:16David ColeFixed in Version => CMake 2.8.7
2012-07-09 06:52David ColeNote Added: 0029973
2012-07-09 06:52David ColeStatusresolved => closed

Notes
(0027318)
vastevaste   
2011-09-01 23:38   
(edited on: 2011-09-01 23:39)
Build attached CMakeLists.txt to try. CMake 2.5 seems to have the same behavior.




# make
# echo include CMakeFiles/test.dir/progress.make >> CMakeFiles/test.dir/build.make
# make clean && make

cmake_minimum_required(VERSION 2.8)

project(test)
macro(addtests)
    foreach(x ${ARGN})
        add_custom_command(OUTPUT ${x} COMMAND touch ${x})
    endforeach(x)
endmacro(addtests)

set(files test1.txt test2.txt test3.txt test4.txt test5.txt test6.txt)
addtests(${files})
add_custom_target(test ALL DEPENDS ${files})
(0027411)
vastevaste   
2011-09-12 23:13   
It seems to be a problem with add_custom_target. I tried adding a c++ target tutorial.cxx by changing:
   add_custom_target(test ALL DEPENDS ${files})
to:
   add_executable(Tut tutorial.cxx ${files})

This then gives:

$ grep -R progress .
./CMakeFiles/Tut.dir/build.make:# Include the progress variables for this target.
./CMakeFiles/Tut.dir/build.make:include CMakeFiles/Tut.dir/progress.make
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_1)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_2)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_3)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_4)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_5)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_6)
./CMakeFiles/Tut.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_7)

However, if I have:
   add_custom_target(test ALL DEPENDS ${files})
instead, I only get the following:

$ grep -R progress .
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_1)
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_2)
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_3)
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_4)
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_5)
./CMakeFiles/test.dir/build.make: $(CMAKE_COMMAND) -E cmake_progress_report /home/vaste/src/cmaketest/build/CMakeFiles $(CMAKE_PROGRESS_6)

Notice how there's no include directive.
(0027413)
vastevaste   
2011-09-13 05:53   
Added an (admittedly ugly) patch that fixes it for me.
(0027980)
David Cole   
2011-12-13 20:34   
Fix pushed to 'next':

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7ab1162eaa1490be745f2b2a24ba7b4a3ec69112 [^]
(0029973)
David Cole   
2012-07-09 06:52   
Closing resolved issues that have not been updated in more than 4 months.