MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012058CMakeModulespublic2011-04-07 20:542016-06-10 14:31
ReporterSteve Goldhaber 
Assigned ToPhilip Lowman 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformApple MacOSOS XOS Version10.4.10
Product VersionCMake 2.8.4 
Target VersionFixed in Version 
Summary0012058: FindBoost.cmake uses environment variables to override the command line
DescriptionThe variables, BOOST_INCLUDEDIR and BOOST_LIBRARYDIR are set if they have values in the environment, even if they were specified on the command line. This is opposite of usual behavior (even BOOST_ROOT checks for a command line value first).
Steps To ReproduceSet BOOST_INCLUDEDIR and/or BOOST_LIBRARYDIR as environment variables. Run cmake on a CMakeLists.txt file containing a find_package(Boost ...) command and check the values which were used (Setting Boost_DEBUG on helps).
Additional Information## This is the offending code (starts at line 522):
  # If BOOST_INCLUDEDIR was defined in the environment, use it.
  if( NOT $ENV{BOOST_INCLUDEDIR} STREQUAL "" )
    set(BOOST_INCLUDEDIR $ENV{BOOST_INCLUDEDIR})
  endif()

  # If BOOST_LIBRARYDIR was defined in the environment, use it.
  if( NOT $ENV{BOOST_LIBRARYDIR} STREQUAL "" )
    set(BOOST_LIBRARYDIR $ENV{BOOST_LIBRARYDIR})
  endif()

##I think it should be:
  # If BOOST_INCLUDEDIR was defined in the environment but not on the command line, use it.
  if( NOT BOOST_INCLUDEDIR AND NOT $ENV{BOOST_INCLUDEDIR} STREQUAL "" )
    set(BOOST_INCLUDEDIR $ENV{BOOST_INCLUDEDIR})
  endif()

  # If BOOST_LIBRARYDIR was defined in the environment but not on the command line, use it.
  if( NOT BOOST_LIBRARYDIR AND NOT $ENV{BOOST_LIBRARYDIR} STREQUAL "" )
    set(BOOST_LIBRARYDIR $ENV{BOOST_LIBRARYDIR})
  endif()
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-04-07 20:54Steve GoldhaberNew Issue
2012-08-11 11:09David ColeStatusnew => backlog
2012-08-11 11:09David ColeNote Added: 0030250
2012-08-18 15:30Philip LowmanStatusbacklog => assigned
2012-08-18 15:30Philip LowmanAssigned To => Philip Lowman
2016-06-10 14:28Kitware RobotNote Added: 0041831
2016-06-10 14:28Kitware RobotStatusassigned => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0030250)
David Cole   
2012-08-11 11:09   
Sending old, never assigned issues to the backlog.

(The age of the bug, plus the fact that it's never been assigned to anyone means that nobody is actively working on it...)

If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: http://www.cmake.org/mailman/listinfo/cmake [^]

It's easy to re-activate a bug here if you can find a CMake developer who has the bandwidth to take it on, and ferry a fix through to our 'next' branch for dashboard testing.
(0041831)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.