MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011705CMakeModulespublic2011-01-16 05:312011-07-08 17:57
ReporterAndreas Schneider. 
Assigned ToMathieu Malaterre 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0011705: Improved version of FindOpenSSL (Win64, pkgconfig...)
DescriptionI've improved the OpenSSL module to handle more directories on Windows and use pkgconfig on UNIX.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? FindOpenSSL.cmake (6,699) 2011-01-16 05:31
https://public.kitware.com/Bug/file/3626/FindOpenSSL.cmake
patch 0001-Modules-Added-an-improved-version-of-OpenSSL.patch (12,326) 2011-01-16 06:31
https://public.kitware.com/Bug/file/3627/0001-Modules-Added-an-improved-version-of-OpenSSL.patch
Issue History
Date ModifiedUsernameFieldChange
2011-01-16 05:31Andreas Schneider.New Issue
2011-01-16 05:31Andreas Schneider.File Added: FindOpenSSL.cmake
2011-01-16 05:57Mathieu MalaterreAssigned To => Mathieu Malaterre
2011-01-16 05:57Mathieu MalaterreStatusnew => assigned
2011-01-16 06:01Andreas Schneider.Note Added: 0024726
2011-01-16 06:31Andreas Schneider.File Added: 0001-Modules-Added-an-improved-version-of-OpenSSL.patch
2011-03-28 12:01Mathieu MalaterreNote Added: 0025931
2011-03-28 12:01Mathieu MalaterreStatusassigned => feedback
2011-03-28 12:06Andreas Schneider.Note Added: 0025932
2011-03-28 12:06Andreas Schneider.Statusfeedback => assigned
2011-03-28 12:50Andreas Schneider.Note Added: 0025937
2011-03-30 04:01Mathieu MalaterreNote Added: 0025963
2011-03-30 04:01Mathieu MalaterreStatusassigned => closed
2011-03-30 04:01Mathieu MalaterreResolutionopen => fixed
2011-03-30 04:01Mathieu MalaterreFixed in Version => CMake 2.8.5
2011-07-08 17:57David ColeTarget Version => CMake 2.8.5

Notes
(0024726)
Andreas Schneider.   
2011-01-16 06:01   
I could send a git patch if you want. The current version could be found here:

http://git.cryptomilk.org/projects/cmake-tools.git/tree/modules/openssl/FindOpenSSL.cmake [^]
(0025931)
Mathieu Malaterre   
2011-03-28 12:01   
Your changes are too big for a quick import.

Quick questions, are you sure about:

1.
if (OPENSSL_LIBRARIES AND OPENSSL_INCLUDE_DIRS)
    # in cache already
    set(OPENSSL_FOUND TRUE)
else (OPENSSL_LIBRARIES AND OPENSSL_INCLUDE_DIRS)


2.
 find_path(OPENSSL_INCLUDE_DIR
...
            /usr/local/include
...
    )

3.
 find_path(OPENSSL_INCLUDE_DIR
  ...
 ${_OPENSSL_INCLUDEDIR}
)

Comments:

(1) I do not see why CMake could not handle that for us
(2) I think that /local dir are very special and should not be handled in module
(3) I think the behavior is to have OPENSSL_ROOT_DIR be an ENV var which define the openssl to use. I do not like pkg-config trying to override my settings.

Thanks for comments
(0025932)
Andreas Schneider.   
2011-03-28 12:06   
We discussed more changes and improvements I will cover soon. These things are included ...
(0025937)
Andreas Schneider.   
2011-03-28 12:50   
http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/asn_openssl_fixes [^]
(0025963)
Mathieu Malaterre   
2011-03-30 04:01   
This has been merged in git. Closing issue then.