MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011630CMakeCMakepublic2010-12-19 12:152011-05-02 14:46
Reporterstarseeker 
Assigned ToDavid Cole 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version 
Target VersionFixed in VersionCMake 2.8.4 
Summary0011630: Enhanced FindTCL.cmake
DescriptionThis issue describes a FindTCL.cmake with a considerable number of new features and enhancements, including:

1) detecting threaded vs. non-threaded tcl
2) determining if Tk is built for X11 or Aqua graphics systems
3) specifying version requirements
4) sorting out multiple installs of Tcl/Tk on one system

(see comments in file more more detail and a complete list)

The hope is that this module could be suitable for inclusion as a contribution back into CMake proper, but it likely needs more polishing (at a minimum). So two questions - 1) is there interest in including this in CMake and 2) if so, what improvements would be needed?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? FindTCL.cmake (39,528) 2010-12-19 12:15
https://public.kitware.com/Bug/file/3586/FindTCL.cmake
Issue History
Date ModifiedUsernameFieldChange
2010-12-19 12:15starseekerNew Issue
2010-12-19 12:15starseekerFile Added: FindTCL.cmake
2010-12-19 14:36starseekerNote Added: 0024265
2010-12-20 08:53Brad KingNote Added: 0024279
2011-01-17 12:14David ColeAssigned To => David Cole
2011-01-17 12:14David ColeStatusnew => assigned
2011-01-17 12:18David ColeNote Added: 0024769
2011-01-17 12:18David ColeStatusassigned => resolved
2011-01-17 12:18David ColeFixed in Version => CMake 2.8.4
2011-01-17 12:18David ColeResolutionopen => no change required
2011-05-02 14:46David ColeNote Added: 0026343
2011-05-02 14:46David ColeStatusresolved => closed

Notes
(0024265)
starseeker   
2010-12-19 14:36   
Hmm - perhaps I should be working with the find_package version argument for some of this, although I don't see an exact correspondence to the setting of MIN and MAX versions...

Is the package configuration file something that is expected of the installed package that find_package is looking for, or something provided by the module author as part of CMake? If it's the former the logic will probably have to stay in FindTCL, although I can try to make the variable naming conventions match those I'm seeing in the find_package docs...
(0024279)
Brad King   
2010-12-20 08:53   
See here for our Module contribution policy:

  http://www.cmake.org/Wiki/CMake:Module_Maintainers [^]

> Is the package configuration file something that is expected of the installed package that find_package is looking for

Yes. If the package to be found is CMake-aware it should provide this file. I don't know if any projects not built by CMake provide the files though. Tcl/Tk doesn't AFAIK. Therefore the find-module must do all the work.
(0024769)
David Cole   
2011-01-17 12:18   
Resolving this issue as "no change required" for now. Although this is not the end of the discussion here, I'm sure.

The file attached here is basically a complete re-write of the existing FindTCL.cmake. In order for us to include it in CMake, the author will have to volunteer as the CMake Module maintainer as outline on this page: http://www.cmake.org/Wiki/CMake:Module_Maintainers [^]

As the module maintainer, we would also request your help with any issues that arise related to the module, and hope that you could contribute timely fixes for any dashboard issues that arise as a result of changes to the module.

For now, I'm resolving this issue. If you are interested in becoming the module maintainer for it, then please re-open the issue, let us know about it, and we'll get you set up as a developer responsible for the FindTCL module. And then we'll assign this bug to you...!

Thanks.
(0026343)
David Cole   
2011-05-02 14:46   
Closing resolved issues that have not been updated in more than 3 months.