MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011554CMakeCTestpublic2010-12-01 16:092011-01-12 07:57
ReporterTommy Edvardsen 
Assigned ToBrad King 
PrioritynormalSeveritytextReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.3 
Target VersionCMake 2.8.4Fixed in VersionCMake 2.8.4 
Summary0011554: Incorrect description for ctest_sleep command
DescriptionThe description of ctest_sleep command is incorrect and confusing:
"With three arguments it will wait for time2 - time1 - duration seconds."

In source file "cmCTestSleepCommand.cxx" the calculation is as follows:
duration = (time1 + duration - time2);
cmCTestScriptHandler::SleepInSeconds(duration);

The correct description would then be:
"With three arguments it will wait for time1 + duration - time2 seconds."

It is also worth noting that the description should include that no sleep will be performed if time1 + duration is greater than time2.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-01 16:09Tommy EdvardsenNew Issue
2010-12-01 16:30Tommy EdvardsenNote Added: 0023652
2010-12-09 10:38Brad KingAssigned To => Brad King
2010-12-09 10:38Brad KingStatusnew => assigned
2010-12-09 10:38Brad KingNote Added: 0023842
2010-12-09 10:38Brad KingStatusassigned => closed
2010-12-09 10:38Brad KingResolutionopen => fixed
2011-01-12 07:57David ColeFixed in Version => CMake 2.8.4
2011-01-12 07:57David ColeTarget Version => CMake 2.8.4

Notes
(0023652)
Tommy Edvardsen   
2010-12-01 16:30   
Correction to my last sentence.
Sleep will only be performed if time1 + duration is greater than time2. For all other situations no sleep will be performed. This should be clearified in the description.
(0023842)
Brad King   
2010-12-09 10:38   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7145ca67 [^]