MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011461CMakeCMakepublic2010-11-14 08:182012-03-16 13:07
ReporterRobert Lenhardt 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.3 
Target VersionCMake 2.8.4Fixed in VersionCMake 2.8.4 
Summary0011461: finish midl support for VS2010 Generator
DescriptionThe support for processing idl files is missing from the VS2010 Generator. Therefore idl files are now added as headers without processing. I added a patch which adds idl files under <Midl> tags and inserts file output options to the midl options in backward correspondance to the previous VS Generators. This works for my idl files. I did not insert preprocessor definitions to the midl options, as there where problems with quoted defines in previous midl versions (see Issue 8165). The new midl seems to accept quoted defines though.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0008165closed David Cole vs2005 midl chokes on CMAKE_INTDIR 
has duplicate 0010687closed David Cole VC 2010 generator ignores .idl Files and doesn't produce .tlb file 
related to 0013043closed Kitware Robot IDL files do not supported if used NMake Makefiles generator 
Attached Filespatch vc10midl.patch (2,332) 2010-11-14 08:18
https://public.kitware.com/Bug/file/3497/vc10midl.patch
Issue History
Date ModifiedUsernameFieldChange
2010-11-14 08:18Robert LenhardtNew Issue
2010-11-14 08:18Robert LenhardtFile Added: vc10midl.patch
2010-11-15 16:14Bill HoffmanNote Added: 0023272
2010-11-15 16:35Robert LenhardtNote Added: 0023273
2010-12-15 12:13David ColeRelationship addedrelated to 0008165
2010-12-15 12:14David ColeAssigned To => David Cole
2010-12-15 12:14David ColeStatusnew => assigned
2010-12-15 12:14David ColeRelationship addedhas duplicate 0010687
2010-12-17 07:35David ColeTarget Version => CMake 2.8.4
2011-01-05 09:23David ColeNote Added: 0024412
2011-01-05 11:08David ColeNote Added: 0024419
2011-01-05 11:08David ColeStatusassigned => resolved
2011-01-05 11:08David ColeFixed in Version => CMake 2.8.4
2011-01-05 11:08David ColeResolutionopen => fixed
2011-05-02 14:45David ColeNote Added: 0026306
2011-05-02 14:45David ColeStatusresolved => closed
2012-03-16 13:07Brad KingRelationship addedchild of 0013043
2012-03-16 13:07Brad KingRelationship replacedrelated to 0013043

Notes
(0023272)
Bill Hoffman   
2010-11-15 16:14   
Is this comparable to what happens with VS 8 and 9 with idl files?
(0023273)
Robert Lenhardt   
2010-11-15 16:35   
No VS10 was missing special treatment of idl files to compile it with midl. VS8/9 generator has put them correctly under midl, but midl can not handle quoted preprocessor defintions. I have attached a midl test to issue 8165, this should detect the missing midl support in VS2010 too.
(0024412)
David Cole   
2011-01-05 09:23   
I'm working on fixing this (and its related issues) and ran into the following known, but apparently not yet fixed, problem with VS10:
https://connect.microsoft.com/VisualStudio/feedback/details/554333/midl-compiler-fails-when-include-directory-contains-space?wa=wsignin1.0 [^]

This means the test added to verify that it works on all our Visual Studio dashboards will not work properly in its source tree location since the vast majority of our dashboards run in a path that contains "/My Tests/" as part of its path name.

I'll have to copy the test source tree to a known location without spaces in the path in order to run this test successfully on the VS10 dashboards.
(0024419)
David Cole   
2011-01-05 11:08   
Fixed by this commit, just pushed to CMake 'next':
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=13caaa3eb74a11dbf067409ea129321718d34dfe [^]

I expect this will make it into the upcoming CMake 2.8.4 release. I will update this and related issues with another note if that expectation turns out to be too optimistic... :-)
(0026306)
David Cole   
2011-05-02 14:45   
Closing resolved issues that have not been updated in more than 3 months.