MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011412CMakeCMakepublic2010-11-06 06:402011-01-12 07:45
ReporterChristian Ehrlicher 
Assigned ToBrad King 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.3 
Target VersionCMake 2.8.4Fixed in VersionCMake 2.8.4 
Summary0011412: Speedup calls to find_library and find_path
DescriptioncmFindLibraryCommand and others initialize the documentation in the ctor. This doesn't make sense and slows down cmake execution (especially because it looks like for every find_foo command a new cmFindFoo instance is created). I've split out the generation of documentation to the (already virtual) GetFullDocumentation() - call. This speeds up my project for 0000022:0000010 percent (which is 0000041:0000001 second). Maybe it's worth to change all cmFindFoo commands this way?
Attached you can find a patch I used for this quick test. It's against 4.8.3. A diff between the original and the modified output of '--help-full' shows no difference.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff cmake_strstr.diff (10,717) 2010-11-06 06:40
https://public.kitware.com/Bug/file/3478/cmake_strstr.diff
Issue History
Date ModifiedUsernameFieldChange
2010-11-06 06:40Christian EhrlicherNew Issue
2010-11-06 06:40Christian EhrlicherFile Added: cmake_strstr.diff
2010-11-12 10:48Brad KingStatusnew => assigned
2010-11-12 10:48Brad KingAssigned To => Brad King
2010-11-12 10:55Brad KingNote Added: 0023203
2010-11-12 10:55Brad KingStatusassigned => closed
2010-11-12 10:55Brad KingResolutionopen => fixed
2011-01-12 07:45David ColeFixed in Version => CMake 2.8.4
2011-01-12 07:45David ColeTarget Version => CMake 2.8.4

Notes
(0023203)
Brad King   
2010-11-12 10:55   
Good catch, thanks:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5303fbf0 [^]