MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011355CMakeCPackpublic2010-10-23 17:002011-02-07 10:41
ReporterPetri Hodju 
Assigned ToEric NOULARD 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionFixed in VersionCMake-2-8 
Summary0011355: [PATCH] Added optional debian binary package fields
DescriptionThe attached patch adds support for missing debian binary package fields in the debian package generator. It also changes the behaviour a bit by not including the optional fields in the package if the corresponding CMake variable is set but is empty. Here are the added fields and their corresponding CMake variables:

Pre-Depends - CMAKE_DEBIAN_PACKAGE_PREDEPENDS
Enhances - CMAKE_DEBIAN_PACKAGE_ENHANCES
Breaks - CMAKE_DEBIAN_PACKAGE_BREAKS
Conflicts - CMAKE_DEBIAN_PACKAGE_CONFLICTS
Provides - CMAKE_DEBIAN_PACKAGE_PROVIDES
Replaces - CMAKE_DEBIAN_PACKAGE_REPLACES
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0008342closed Eric NOULARD The Deb Generator needs support for the fields Conflicts and Replaces 
Attached Filespatch 0001-added-missing-optional-debian-binary-package-fields.patch (3,430) 2010-10-23 17:00
https://public.kitware.com/Bug/file/3466/0001-added-missing-optional-debian-binary-package-fields.patch
patch 0001-added-missing-optional-debian-binary-package-fields-CORRECTED.patch (3,431) 2010-10-24 12:29
https://public.kitware.com/Bug/file/3467/0001-added-missing-optional-debian-binary-package-fields-CORRECTED.patch
Issue History
Date ModifiedUsernameFieldChange
2010-10-23 17:00Petri HodjuNew Issue
2010-10-23 17:00Petri HodjuFile Added: 0001-added-missing-optional-debian-binary-package-fields.patch
2010-10-23 18:08Eric NOULARDRelationship addedrelated to 0008342
2010-10-24 12:29Petri HodjuFile Added: 0001-added-missing-optional-debian-binary-package-fields-CORRECTED.patch
2010-10-24 12:30Petri HodjuNote Added: 0022668
2010-10-24 15:18Eric NOULARDNote Added: 0022669
2010-10-25 13:47Eric NOULARDStatusnew => assigned
2010-10-25 13:47Eric NOULARDAssigned To => Eric NOULARD
2010-10-25 13:53Eric NOULARDNote Added: 0022673
2010-10-25 14:46Eric NOULARDNote Added: 0022675
2010-10-25 14:48Eric NOULARDNote Added: 0022678
2010-10-25 14:48Eric NOULARDStatusassigned => resolved
2010-10-25 14:48Eric NOULARDFixed in Version => CMake-2-8
2010-10-25 14:48Eric NOULARDResolutionopen => fixed
2011-02-07 10:41David ColeNote Added: 0025314
2011-02-07 10:41David ColeStatusresolved => closed

Notes
(0022668)
Petri Hodju   
2010-10-24 12:30   
There was still bug in the patch. The url field inclusion test was missing dereference operator for the second operand.
(0022669)
Eric NOULARD   
2010-10-24 15:18   
Thank you Petri,

I'll try to have a look (and may be merge your patch)
during this week.
(0022673)
Eric NOULARD   
2010-10-25 13:53   
I'm reviewing the patch.
Small note to say that the vars are

CPACK_DEBIAN_PACKAGE_xxx
and not
CMAKE_DEBIAN_PACKAGE_xxx as stated in the initial
 description...

i.e. the patch is good the description is not.
(0022675)
Eric NOULARD   
2010-10-25 14:46   
I've just merged your patch into next.
I did add some documentation about the extra fields in CPackDeb.cmake
that way one can have the CPackDeb documentation with

cmake --help-module CPackDeb

(it was already the case for other options).

commit a74972402910610ab3ab62066d6b9e65b5202078
Author: Eric NOULARD <eric.noulard@gmail.com>
Date: Mon Oct 25 20:40:45 2010 +0200

    CPackDeb Added several optional debian binary package fields
    
    This fixes bugs 0011355 and 0008342.
    The merged patch is a contribution from Michael Lasmanis and Petri Hodju
    with some extra documentation added by the merger.
(0022678)
Eric NOULARD   
2010-10-25 14:48   
commit a74972402910610ab3ab62066d6b9e65b5202078
Author: Eric NOULARD <eric.noulard@gmail.com>
Date: Mon Oct 25 20:40:45 2010 +0200

    CPackDeb Added several optional debian binary package fields
    
    This fixes bugs 0011355 and 0008342.
    The merged patch is a contribution from Michael Lasmanis and Petri Hodju
    with some extra documentation added by the merger.
(0025314)
David Cole   
2011-02-07 10:41   
Closing resolved issues that have not been updated in more than 3 months.