MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011273CMakeCMakepublic2010-09-29 04:002010-10-26 16:34
ReporterRolf Eike Beer 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0011273: FindSubversion breaks with German SilkSVN
DescriptionOn a Win32 system with a German version of SilkSVN I can't run CMake again on the working copy as the cache is displayed as corrupted. The cause is that the regular expression to find the version number will not match and put everything from the "svn --version" output into the cache, which contains umlauts and other funny characters.

The attached patch fixes the regexp to not only match " version " but also " Version " as it's in the German output. I have no idea what will happen on a French or Japanese system. This should be easy to test as it happens also on a German Linux system.
Steps To Reproduce
Additional InformationI could reproduce this on a Linux system by setting the LANG environment variable to de_DE.UTF-8. I'm not sure if there's an equivalent environment variable for Windows. If so, you could set it to en_US.UTF-8, as a workaround.
TagsNo tags attached.
Relationships
Attached Filespatch 0001-fix-FindSubversion-with-German-localized-client-1127.patch (1,042) 2010-10-06 18:25
https://public.kitware.com/Bug/file/3432/0001-fix-FindSubversion-with-German-localized-client-1127.patch
patch 0001-make-Subversion-version-detection-work-with-all-loca.patch (1,522) 2010-10-07 10:37
https://public.kitware.com/Bug/file/3437/0001-make-Subversion-version-detection-work-with-all-loca.patch
Issue History
Date ModifiedUsernameFieldChange
2010-09-29 04:00Rolf Eike BeerNew Issue
2010-10-06 18:25Rolf Eike BeerFile Added: 0001-fix-FindSubversion-with-German-localized-client-1127.patch
2010-10-07 06:22Marcel LooseStatusnew => acknowledged
2010-10-07 06:22Marcel LooseAdditional Information Updated
2010-10-07 10:11Brad KingStatusacknowledged => assigned
2010-10-07 10:11Brad KingAssigned To => Brad King
2010-10-07 10:12Brad KingNote Added: 0022433
2010-10-07 10:12Brad KingStatusassigned => closed
2010-10-07 10:12Brad KingResolutionopen => fixed
2010-10-07 10:37Rolf Eike BeerNote Added: 0022435
2010-10-07 10:37Rolf Eike BeerStatusclosed => feedback
2010-10-07 10:37Rolf Eike BeerResolutionfixed => reopened
2010-10-07 10:37Rolf Eike BeerFile Added: 0001-make-Subversion-version-detection-work-with-all-loca.patch
2010-10-07 11:13Brad KingNote Added: 0022437
2010-10-07 11:13Brad KingStatusfeedback => closed
2010-10-07 11:13Brad KingResolutionreopened => fixed
2010-10-26 16:34David ColeFixed in Version => CMake 2.8.3
2010-10-26 16:34David ColeTarget Version => CMake 2.8.3

Notes
(0022433)
Brad King   
2010-10-07 10:12   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=42126aaf [^]
(0022435)
Rolf Eike Beer   
2010-10-07 10:37   
Now that the first fix is merged I find the proper solution which was only a few lines down in the same file.
(0022437)
Brad King   
2010-10-07 11:13   
[smacks forehead]

Yes, of course that is the correct fix. Thanks.

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d2f8c5f8 [^]