MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011263CMakeModulespublic2010-09-23 11:282010-11-09 22:57
ReporterSascha Kratky 
Assigned ToJames Bigler 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0011263: FindCUDA.cmake does not set CUDA_SDK_ROOT_DIR correctly under Windows
DescriptionCUDA_SDK_ROOT_DIR is set in the following way:

# Look for the SDK stuff
find_path(CUDA_SDK_ROOT_DIR common/inc/cutil.h
  "$ENV{NVSDKCUDA_ROOT}"
  "[HKEY_LOCAL_MACHINE\\SOFTWARE\\NVIDIA Corporation\\Installed Products\\NVIDIA SDK 10\\Compute;InstallDir]"
  "/Developer/GPU\ Computing/C"
  )

The environment variable and registry path is missing a trailing "/C". Both the env variable and the registry key are set to the enclosing folder an do not include the "/C" (as of CUDA SDK 3.1).

Corrected find_path command:
# Look for the SDK stuff
find_path(CUDA_SDK_ROOT_DIR common/inc/cutil.h
  "$ENV{NVSDKCUDA_ROOT}/C"
  "[HKEY_LOCAL_MACHINE\\SOFTWARE\\NVIDIA Corporation\\Installed Products\\NVIDIA SDK 10\\Compute;InstallDir]/C"
  "/Developer/GPU\ Computing/C"
  )
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-23 11:28Sascha KratkyNew Issue
2010-09-24 01:40James BiglerStatusnew => assigned
2010-09-24 01:40James BiglerAssigned To => James Bigler
2010-09-24 23:29Kovarththanan RajaratnamCategoryCMake => Modules
2010-10-04 17:09James BiglerNote Added: 0022404
2010-10-04 18:18James BiglerNote Added: 0022405
2010-10-05 03:13Sascha KratkyNote Added: 0022406
2010-10-05 12:36James BiglerNote Added: 0022411
2010-10-06 13:44James BiglerNote Added: 0022421
2010-10-06 13:45David ColeNote Added: 0022422
2010-10-06 13:45David ColeStatusassigned => resolved
2010-10-06 13:45David ColeFixed in Version => CMake 2.8.3
2010-10-06 13:45David ColeResolutionopen => fixed
2010-10-06 13:45David ColeTarget Version => CMake 2.8.3
2010-11-09 22:57Philip LowmanStatusresolved => closed

Notes
(0022404)
James Bigler   
2010-10-04 17:09   
I'm looking at the installations I have, and it appears that the new path should be:

NVSDKCOMPUTE_ROOT/C and not NVSDKCUDA_ROOT/C. In CUDA 3.0 NVSDKCOMPUTE_ROOT replaced NVSDKCUDA_ROOT and moved all the contents into the C directory.

If you feel I'm wrong, let me know, because I'm only going to add the NVSDKCOMPUTE_ROOT/C path.
(0022405)
James Bigler   
2010-10-04 18:18   
I checked in the fix into next. We'll just have to wait for it to make it into the release. Hopefully it will make it into the 2.8.3 release.

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c9bcf5a065facaac96b8ee3ef1361be15848722f [^]
commit c9bcf5a065facaac96b8ee3ef1361be15848722f
Merge: 9965fe7 1df8516
Author: James Bigler <jamesbigler@gmail.com>
AuthorDate: Mon Oct 4 16:13:47 2010 -0600
Commit: James Bigler <jamesbigler@gmail.com>
CommitDate: Mon Oct 4 16:13:47 2010 -0600

   Merge branch 'topics/Fix-0011263-CUDA_SDK_PATH' into next
(0022406)
Sascha Kratky   
2010-10-05 03:13   
The path NVSDKCOMPUTE_ROOT/C is correct. I overlooked that change in my original bug report.

I have looked at your bugfix and I suggest that you make the following additional change:

find_path(CUDA_SDK_ROOT_DIR common/inc/cutil.h
 618 "$ENV{NVSDKCOMPUTE_ROOT}/C"
 619 "$ENV{NVSDKCUDA_ROOT}"
 620 "[HKEY_LOCAL_MACHINE\\SOFTWARE\\NVIDIA Corporation\\Installed Products\\NVIDIA SDK 10\\Compute;InstallDir]"
 621 "/Developer/GPU\ Computing/C"
 622 )

The registry key reference in line 620 above should also have "/C" as a suffix, i.e.:
 620 "[HKEY_LOCAL_MACHINE\\SOFTWARE\\NVIDIA Corporation\\Installed Products\\NVIDIA SDK 10\\Compute;InstallDir]/C"

On my machine the registry key does not include the trailing /C.
(0022411)
James Bigler   
2010-10-05 12:36   
I'm not seeing that key on my machine. I'm trying to get a clearer picture of what will be supported before I start adding any more items.
(0022421)
James Bigler   
2010-10-06 13:44   
My patch should be in 2.8.3.RC2. Please try it out and let me know if it doesn't work properly for you.
(0022422)
David Cole   
2010-10-06 13:45   
In CMake 2.8.3-rc2