MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011143CMakeCPackpublic2010-08-18 07:082011-05-02 14:45
ReporterMike McQuaid 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.4Fixed in VersionCMake 2.8.4 
Summary0011143: CPACK_NSIS_MUI_ICON only used when CPACK_NSIS_MUI_UNIICON also set
DescriptionCPACK_NSIS_MUI_ICON can only used when CPACK_NSIS_MUI_UNIICON also set as the C++ code seems to require them both to have a value. Surely this could be an || rather than an && here as there's no reason why the user should have to set both to have one change.

If this is not intentional, let me know and I'll create a patch.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-18 07:08Mike McQuaidNew Issue
2010-12-13 07:06Mike McQuaidNote Added: 0023914
2010-12-15 11:32David ColeStatusnew => assigned
2010-12-15 11:32David ColeAssigned To => David Cole
2011-01-06 09:07Mike McQuaidNote Added: 0024454
2011-01-06 16:56David ColeTarget Version => CMake 2.8.4
2011-01-06 17:02David ColeNote Added: 0024497
2011-01-06 17:02David ColeStatusassigned => resolved
2011-01-06 17:02David ColeFixed in Version => CMake 2.8.4
2011-01-06 17:02David ColeResolutionopen => fixed
2011-05-02 14:45David ColeNote Added: 0026336
2011-05-02 14:45David ColeStatusresolved => closed

Notes
(0023914)
Mike McQuaid   
2010-12-13 07:06   
4 months later ping. If I shouldn't be bugs on the bug tracker can you suggest the best way of getting these looked at?

Thanks!
(0024454)
Mike McQuaid   
2011-01-06 09:07   
Pull request created at https://github.com/Kitware/CMake/pull/2 [^]
(0024497)
David Cole   
2011-01-06 17:02   
Fixed in this git commit, just pushed to 'next':
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fec32328b17662d44bfa7769e672529c24e1697f [^]

Should make it into 2.8.4...

Thanks, Mike McQuaid, for the patch / pull request!
(0026336)
David Cole   
2011-05-02 14:45   
Closing resolved issues that have not been updated in more than 3 months.