MantisBT - CMake
View Issue Details
0010889CMakeCMakepublic2010-06-24 20:322016-06-10 14:31
Davi Arnaut 
Kitware Robot 
normalminoralways
closedmoved 
CMake-2-8 
 
0010889: SET is prone to misuse
The SET syntax for variable names accepts oddly named variables such as:

SET(FOO_DEFINES"-DFOO")

even though it is likely a mistake.

Is there a formal description of the accept variable names? In any case, it would be nice if CMake could warn (perhaps in debug mode) about suspicious variable names.
No tags attached.
Issue History
2010-06-24 20:32Davi ArnautNew Issue
2011-01-17 13:06David ColeNote Added: 0024779
2011-01-17 13:06David ColeAssigned To => David Cole
2011-01-17 13:06David ColeStatusnew => assigned
2011-10-25 22:46David ColeAssigned ToDavid Cole =>
2011-10-25 22:46David ColeStatusassigned => backlog
2016-06-10 14:28Kitware RobotNote Added: 0041716
2016-06-10 14:28Kitware RobotStatusbacklog => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:28Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0024779)
David Cole   
2011-01-17 13:06   
Define "suspicious" and "odd" -- since CMake has not enforced variable names from day 1, there are probably hundreds of projects that use variable names that are presently *valid* but that we would flag as "suspicious" based on reasonable assumptions.

How can we make a change here without breaking such projects....?
(0041716)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.