MantisBT - CMake
View Issue Details
0010798CMakeCMakepublic2010-06-07 06:372011-11-11 10:45
Ivan Shynkarenka 
Bill Hoffman 
normalmajoralways
closedfixed 
CMake-2-8 
CMake 2.8.5CMake 2.8.5 
0010798: VS 2010 generator improperly generates AdditionalIncludeDirectories nodes
Consider we have the following config:

CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
PROJECT(TEST)

ADD_EXECUTABLE(TEST test.cpp)

# This define include directories for ALL targets.
INCLUDE_DIRECTORIES("Subdir1" "Subdir2")

# This define include directories only for TEST targets.
SET_PROPERTY(TARGET TEST APPEND PROPERTY COMPILE_FLAGS "/ISubdir3")

VS 2008 generator behaviour (RIGHT behaviour):
    <Tool AdditionalOptions=" /Zm1000 /ISubdir3"
        AdditionalIncludeDirectories="Subdir1;Subdir2;" />

VS 2010 generator behaviour (WRONG behaviour):
    <ClCompile>
      <AdditionalOptions> /Zm1000 %(AdditionalOptions)</AdditionalOptions>
      <AdditionalIncludeDirectories>Subdir1;Subdir2;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
      <AdditionalIncludeDirectories>Subdir3</AdditionalIncludeDirectories>
    </ClCompile>

You may see VS 2010 creates extra <AdditionalIncludeDirectories> node. As the result all previous nodes are ignored and project will have only one additional include directory - Subdir3.
No tags attached.
zip testcase.zip (1,440) 2010-06-07 06:37
https://public.kitware.com/Bug/file/3167/testcase.zip
diff cmake-2.8.2_patch_for_bug_10798.diff (788) 2010-10-10 14:13
https://public.kitware.com/Bug/file/3445/cmake-2.8.2_patch_for_bug_10798.diff
Issue History
2010-06-07 06:37Ivan ShynkarenkaNew Issue
2010-06-07 06:37Ivan ShynkarenkaFile Added: testcase.zip
2010-07-13 09:27Bill HoffmanStatusnew => assigned
2010-07-13 09:27Bill HoffmanAssigned To => Bill Hoffman
2010-10-10 14:13Karl WallnerNote Added: 0022468
2010-10-10 14:13Karl WallnerFile Added: cmake-2.8.2_patch_for_bug_10798.diff
2011-06-18 08:02David ColeNote Added: 0026907
2011-06-18 08:02David ColeStatusassigned => resolved
2011-06-18 08:02David ColeFixed in Version => CMake 2.8.5
2011-06-18 08:02David ColeResolutionopen => fixed
2011-06-18 08:02David ColeTarget Version => CMake 2.8.5
2011-11-11 10:45David ColeNote Added: 0027774
2011-11-11 10:45David ColeStatusresolved => closed

Notes
(0022468)
Karl Wallner   
2010-10-10 14:13   
Attached a fix for this bug.
(0026907)
David Cole   
2011-06-18 08:02   
Fixed by this (and parent) git commits:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=27aa446352b882c7bbda269a3770fec8fa24eb57 [^]
(0027774)
David Cole   
2011-11-11 10:45   
Closing resolved issues that have not been updated in more than 4 months.