MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010764CMakeModulespublic2010-05-26 18:422011-05-02 14:46
ReporterCuran 
Assigned ToDavid Cole 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionFixed in VersionCMake 2.8.4 
Summary0010764: FindGettext.cmake should check for library support too
DescriptionThe KDE version of this CMake module checks in addition to the executable checks whether Gettext is built into libc or if it's provided by a standalone library. I'd like to see this functionality in the mainline FindGettext.cmake as it's helpful outside of KDE.

The attached patch includes a minimal version of what I like to see and was taken from the KDE version of this script. It's a rather quick-and-dirty fix to show what I've in mind.
Steps To Reproduce
Additional InformationThis bug was first reported to Debian, you can find the bug report at <http://bugs.debian.org/583258>. [^]
TagsNo tags attached.
Relationships
Attached Filespatch add_missing_functionality.patch (2,889) 2010-05-26 18:42
https://public.kitware.com/Bug/file/3145/add_missing_functionality.patch
Issue History
Date ModifiedUsernameFieldChange
2010-05-26 18:42CuranNew Issue
2010-05-26 18:42CuranFile Added: add_missing_functionality.patch
2011-01-17 16:05David ColeAssigned To => David Cole
2011-01-17 16:05David ColeStatusnew => assigned
2011-01-17 16:07David ColeNote Added: 0024814
2011-01-17 16:07David ColeStatusassigned => resolved
2011-01-17 16:07David ColeFixed in Version => CMake 2.8.4
2011-01-17 16:07David ColeResolutionopen => no change required
2011-05-02 14:46David ColeNote Added: 0026352
2011-05-02 14:46David ColeStatusresolved => closed

Notes
(0024814)
David Cole   
2011-01-17 16:07   
Resolving this issue as "no change required" for now. Although this is not the end of the discussion here, I'm sure.

We have no volunteer module maintainer for FindGettext.cmake, nor do we have close connections with anybody who uses it frequently. In order for us to accept patches for it in CMake, the author, or somebody intimately familiar with it, will have to volunteer as the CMake Module maintainer as outlined on this page: http://www.cmake.org/Wiki/CMake:Module_Maintainers [^]

As the module maintainer, we would also request your help with any issues that arise related to the module, and hope that you could contribute timely fixes for any dashboard issues that arise as a result of changes to the module.

For now, I'm resolving this issue. If you are interested in becoming the module maintainer for it, then please re-open the issue, let us know about it, and we'll get you set up as a developer responsible for it. And then we'll assign this bug to you...!

Thanks.
(0026352)
David Cole   
2011-05-02 14:46   
Closing resolved issues that have not been updated in more than 3 months.