MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010704CMakeCMakepublic2010-05-11 13:092011-06-17 18:10
ReporterMcBen 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0010704: don't GenerateManifest flag (/Manifest:NO) doesn't work with VS 2010
DescriptionThe <GenerateManifest> Tag is written into the wrong section.
It is inside the <link> block but should be inside the unnamed <PropertyGroup>.
(where the properties "outdir", "targetname"... are)

So VS2010 won't recognize that flag and will continue generating a manifest.

Example script:
 PROJECT(test2)
 ADD_EXECUTABLE(test2 WIN32 test.c )
 SET_TARGET_PROPERTIES(test2 PROPERTIES LINK_FLAGS " /MANIFEST:NO")


NB:
The Version Tag is written even when nothing was set ( /version 0.0 ).
I don't believe this is a problem but atleast it doesn't looks nice :)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0011216closed David Cole Link with /MANIFEST even /manifest:no was set 
related to 0011171closed Bill Hoffman Visual Studio 10 solution generation is incorrect 
has duplicate 0012051closed David Cole MSVC, Linker option "/MANIFEST:NO" can not work 
related to 0008386closed David Cole duplicate manifest entries on link 
Attached Filespatch 0001-fixed-VS2010-GenerateManifest-flag.patch (3,567) 2010-06-04 02:19
https://public.kitware.com/Bug/file/3165/0001-fixed-VS2010-GenerateManifest-flag.patch
Issue History
Date ModifiedUsernameFieldChange
2010-05-11 13:09McBenNew Issue
2010-06-04 02:19McBenFile Added: 0001-fixed-VS2010-GenerateManifest-flag.patch
2010-06-04 02:21McBenNote Added: 0020922
2010-12-15 09:44David ColeAssigned To => Bill Hoffman
2010-12-15 09:44David ColeStatusnew => assigned
2011-01-28 04:33gregmasterNote Added: 0025119
2011-02-08 12:15David ColeAssigned ToBill Hoffman => David Cole
2011-02-08 12:15David ColeRelationship addedrelated to 0011216
2011-02-08 12:16David ColeRelationship addedrelated to 0011171
2011-02-08 12:17David ColeRelationship addedrelated to 0008386
2011-02-09 13:06David ColeNote Added: 0025354
2011-02-09 13:06David ColeStatusassigned => resolved
2011-02-09 13:06David ColeResolutionopen => fixed
2011-02-16 11:42David ColeTarget Version => CMake 2.8.5
2011-04-06 11:08David ColeRelationship addedhas duplicate 0012051
2011-06-06 18:25David ColeStatusresolved => closed
2011-06-06 18:25David ColeNote Added: 0026716
2011-06-17 18:10David ColeFixed in Version => CMake 2.8.5

Notes
(0020922)
McBen   
2010-06-04 02:21   
Patch does:
- add "xml" header
- remove "version 0.0"
- write "GenerateManifest" at correct position
- remove "GenerateManifest" from link flag output
(0025119)
gregmaster   
2011-01-28 04:33   
Confirmed! CMake writes the Linker-Flag to the wrong tag. Please fix this bug in the version 2.8.4.

....and thx for the patch. now we can work again ;)
(0025354)
David Cole   
2011-02-09 13:06   
Fix pushed to 'next'
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=98b448ee9e1fc12181667c5f7431163097466daf [^]
(0026716)
David Cole   
2011-06-06 18:25   
Closing resolved issues that have not been updated in more than 3 months.