MantisBT - CMake
View Issue Details
0010691CMakeModulespublic2010-05-09 11:272010-11-09 22:58
Modestas Vainius 
Philip Lowman 
normalminoralways
closedfixed 
amd64Debian GNU/Linuxsid
CMake-2-8 
CMake 2.8.3CMake 2.8.3 
0010691: Find pangommconfig include directory in FindGTK2.cmake
There is a small bug in FindGTK2.cmake that makes the include dirs not set
properly when using pangomm. Pangomm has, like many of the other libraries, now
two include dirs, one for the arch specific 'config' header, and another dir
for the arch independent headers.
The patch below applies op top of 2.8.1 and master branch.

From 035db011a472d1ff44fd5fdb2731f1973c6a550a Mon Sep 17 00:00:00 2001
From: Modestas Vainius <modestas@vainius.eu>
Date: Sun, 9 May 2010 18:20:41 +0300
Subject: [PATCH 2/2] Find pangommconfig include directory in FindGTK2.

There is a small bug in FindGTK2.cmake that makes the include dirs not set
properly when using pangomm. Pangomm has, like many of the other libraries, now
two include dirs, one for the arch specific 'config' header, and another dir
for the arch independent headers.

Author: Sune Vuorela <reportbug@pusling.com>
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579718 [^]
Origin: vendor, http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=cmake-find-gtk2-pangomm-config;att=1;bug=579718 [^]
Forwarded: yes
Last-Update: 2010-04-30
---
 Modules/FindGTK2.cmake | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Modules/FindGTK2.cmake b/Modules/FindGTK2.cmake
index c871417..202cfb6 100644
--- a/Modules/FindGTK2.cmake
+++ b/Modules/FindGTK2.cmake
@@ -439,6 +439,7 @@ foreach(_GTK2_component ${GTK2_FIND_COMPONENTS})
         _GTK2_FIND_LIBRARY (GTK2_CAIROMM_LIBRARY cairomm true true)
 
         _GTK2_FIND_INCLUDE_DIR(GTK2_PANGOMM_INCLUDE_DIR pangomm.h)
+ _GTK2_FIND_INCLUDE_DIR(GTK2_PANGOMMCONFIG_INCLUDE_DIR pangommconfig.h)
         _GTK2_FIND_LIBRARY (GTK2_PANGOMM_LIBRARY pangomm true true)
 
         _GTK2_FIND_INCLUDE_DIR(GTK2_SIGC++_INCLUDE_DIR sigc++/sigc++.h)
--
1.7.1



No tags attached.
Issue History
2010-05-09 11:27Modestas VainiusNew Issue
2010-08-20 00:00Philip LowmanStatusnew => assigned
2010-08-20 00:00Philip LowmanAssigned To => Philip Lowman
2010-08-20 00:01Philip LowmanNote Added: 0021864
2010-08-20 00:01Philip LowmanStatusassigned => resolved
2010-08-20 00:01Philip LowmanResolutionopen => fixed
2010-09-01 00:19Philip LowmanNote Added: 0022045
2010-09-01 00:19Philip LowmanStatusresolved => assigned
2010-09-01 00:19Philip LowmanTarget Version => CMake 2.8.3
2010-09-01 00:20Philip LowmanStatusassigned => resolved
2010-09-01 00:20Philip LowmanFixed in Version => CMake 2.8.3
2010-11-09 22:58Philip LowmanStatusresolved => closed

Notes
(0021864)
Philip Lowman   
2010-08-20 00:01   
I checked in this fix last week and it will be in CMake 2.8.3. Thank you for filing the bug ticket and attaching the patch.
(0022045)
Philip Lowman   
2010-09-01 00:19   
Reopening to set "Target Release" / "Fixed In Version" fields