MantisBT - CMake | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0010658 | CMake | Modules | public | 2010-05-03 05:39 | 2010-11-09 22:57 |
Reporter | Andreas Mohr | ||||
Assigned To | Miguel Figueroa | ||||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | OS | OS Version | |||
Product Version | CMake-2-8 | ||||
Target Version | CMake 2.8.3 | Fixed in Version | CMake 2.8.3 | ||
Summary | 0010658: FindwxWidgets.cmake: ${wxWidgets_USE_FILE}: does exactly _not_ yield proper Module syntax | ||||
Description | Hi, bugs as of http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/FindwxWidgets.cmake;h=05c6625a81f99288a12afcc691da8ef6da8f921d;hb=HEAD [^] (i.e., current): a) FindwxWidgets.cmake For me, wxWidgets_USE_FILE returns "UsewxWidgets.cmake", which on include(${wxWidgets_USE_FILE}) (as illustrated, I might add) does exactly not yield any success, since it has invalid Module syntax (should have been "UsewxWidgets" _without_ extension, for proper CMAKE_MODULE_PATH lookup as a _module_, not _file_). I.e., _either_ full specification, _or_ module name: # Prefer an existing customized version, but the user might override 186 # the FindwxWidgets module and not the UsewxWidgets one. 187 IF(EXISTS "${wxWidgets_CURRENT_LIST_DIR}/UsewxWidgets.cmake") 188 SET(wxWidgets_USE_FILE 189 "${wxWidgets_CURRENT_LIST_DIR}/UsewxWidgets.cmake") 190 ELSE(EXISTS "${wxWidgets_CURRENT_LIST_DIR}/UsewxWidgets.cmake") 191 SET(wxWidgets_USE_FILE UsewxWidgets.cmake) 192 ENDIF(EXISTS "${wxWidgets_CURRENT_LIST_DIR}/UsewxWidgets.cmake") b) in UsewxWidgets.cmake: 7 # USAGE 8 # SET( wxWidgets_USE_LIBS gl xml xrc ) # optionally: more than wx std libs 9 # FIND_PACKAGE(wxWidgets REQUIRED) 10 # INCLUDE( ${xWidgets_USE_FILE} ) Should call this ${wxWidgets_USE_FILE} to avoid user confusion due to spelling error. Frankly, I'm NOT happy with current quality of implementation (not CMake internal implementation and features, but external parts, mind you): whatever I try, it fails, fails, FAILS: current status of FindWt.cmake is pretty much unusable (externally managed, of course), FindBoost.cmake has many shortcomings, FindwxWidgets.cmake has _immediate_ glaring usability issues (and also 2 dozen or so bug reports). I keep having to apply many manual workarounds whatever I look into. Thanks, Andreas Mohr | ||||
Steps To Reproduce | |||||
Additional Information | |||||
Tags | No tags attached. | ||||
Relationships | |||||
Attached Files | bug-10658-FindwxWidgets-use-file-should-not-include-cmake-extension (730) 2010-05-10 17:12 https://public.kitware.com/Bug/file/3099/bug-10658-FindwxWidgets-use-file-should-not-include-cmake-extension style-usewxwidgets-enhanced-documentation (1,236) 2010-05-10 17:13 https://public.kitware.com/Bug/file/3100/style-usewxwidgets-enhanced-documentation | ||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2010-05-03 05:39 | Andreas Mohr | New Issue | |||
2010-05-10 16:10 | Miguel Figueroa | Status | new => assigned | ||
2010-05-10 16:10 | Miguel Figueroa | Assigned To | => Miguel Figueroa | ||
2010-05-10 17:12 | Miguel Figueroa | File Added: bug-10658-FindwxWidgets-use-file-should-not-include-cmake-extension | |||
2010-05-10 17:13 | Miguel Figueroa | File Added: style-usewxwidgets-enhanced-documentation | |||
2010-05-10 17:16 | Miguel Figueroa | Note Added: 0020701 | |||
2010-05-17 09:33 | Andreas Mohr | Note Added: 0020758 | |||
2010-09-01 10:21 | Miguel Figueroa | Note Added: 0022056 | |||
2010-09-01 10:25 | Miguel Figueroa | Status | assigned => resolved | ||
2010-09-01 10:25 | Miguel Figueroa | Fixed in Version | => CMake 2.8.3 | ||
2010-09-01 10:25 | Miguel Figueroa | Resolution | open => fixed | ||
2010-09-10 00:00 | David Cole | Target Version | => CMake 2.8.3 | ||
2010-11-09 22:57 | Philip Lowman | Status | resolved => closed |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|