MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010532ITKpublic2010-04-10 21:572010-10-21 12:31
ReporterSteve Robbins 
Assigned ToLuis Ibanez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-3-16 
Target VersionFixed in VersionITK-3-20 
Resolution Date
Sprint
Sprint Status
Summary0010532: ITK does not build with tcl 8.5
DescriptionThe file Wrapping/CSwig/IO/itkTkImageViewer2D.cxx needs modification for Tcl 8.5. The build stops with the following errors.

[ 86%] Building CXX object Wrapping/CSwig/IO/CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o
cd /home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Wrapping/CSwig/IO && /usr/bin/c++ -DITKIOTcl_EXPORTS -DSWIG_GLOBAL -Wno-deprecated -ftemplate-depth-50 -Wall -Wno-deprecated -msse2 -w -O3 -DNDEBUG -fPIC -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Algorithms -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/BasicFilters -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Common -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/IO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/FEM -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/NeuralNetworks -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/SpatialObject -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/MetaIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/NrrdIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/NrrdIO -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/DICOMParser -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/DICOMParser -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/expat -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/expat -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/nifti/niftilib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/nifti/znzlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/itkExtHdrs -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Code/Numerics/Statistics -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/v3p/netlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/vcl -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Utilities/vxl/core -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/v3p/netlib -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/vcl -I/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Build/Utilities/vxl/core -I/usr/lib/gdcm-2.0 -I/usr/include/gdcm-2.0 -I/usr/include/python2.5 -I/usr/include/tcl8.5 -I/usr/lib/jvm/default-java/include -o CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o -c /home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx: In member function ‘void itk::TkImageViewer2D::Draw()’:
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: invalid conversion from ‘void*’ to ‘Tcl_Interp*’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: invalid conversion from ‘int’ to ‘void*’
/usr/include/tcl8.5/tkDecls.h:1668: error: too few arguments to function ‘int Tk_PhotoSetSize(Tcl_Interp*, void*, int, int)’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:117: error: at this point in file
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:146: error: invalid conversion from ‘void*’ to ‘Tcl_Interp*’
/usr/include/tcl8.5/tkDecls.h:1651: error: too few arguments to function ‘int Tk_PhotoPutBlock(Tcl_Interp*, void*, Tk_PhotoImageBlock*, int, int, int, int, int)’
/home/steve/Packages/insighttoolkit/build-area/insighttoolkit-3.16.0/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx:146: error: at this point in file
make[3]: *** [Wrapping/CSwig/IO/CMakeFiles/ITKIOTcl.dir/itkTkImageViewer2D.o] Error 1
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch itkTkImageViewer2D.patch (890) 2010-04-11 21:26
https://public.kitware.com/Bug/file/3020/itkTkImageViewer2D.patch
patch itkTkImageViewer2D_b.patch (1,357) 2010-04-25 10:14
https://public.kitware.com/Bug/file/3063/itkTkImageViewer2D_b.patch
Issue History
Date ModifiedUsernameFieldChange
2010-04-10 21:57Steve RobbinsNew Issue
2010-04-11 21:26Steve RobbinsFile Added: itkTkImageViewer2D.patch
2010-04-11 21:27Steve RobbinsNote Added: 0020131
2010-04-25 10:13Luis IbanezStatusnew => assigned
2010-04-25 10:13Luis IbanezAssigned To => Luis Ibanez
2010-04-25 10:14Luis IbanezFile Added: itkTkImageViewer2D_b.patch
2010-04-25 10:15Luis IbanezNote Added: 0020390
2010-04-25 11:50Luis IbanezNote Added: 0020391
2010-08-15 23:29Steve RobbinsStatusassigned => resolved
2010-08-15 23:29Steve RobbinsFixed in Version => ITK-3-20
2010-08-15 23:29Steve RobbinsResolutionopen => fixed
2010-10-21 12:31Gabe HartStatusresolved => closed

Notes
(0020131)
Steve Robbins   
2010-04-11 21:27   
I uploaded the patch I'm using to fix this problem (itkTkImageViewer2D.patch). It compiles now, but I have not yet tested.
(0020390)
Luis Ibanez   
2010-04-25 10:15   
Updated the patch to include conditional #ifdefs so that the changes only apply to Tcl 8.5. New patch file has been attached to this bug report: itkTkImageViewer2D_b.patch
(0020391)
Luis Ibanez   
2010-04-25 11:50   
patch was committed:
http://public.kitware.com/cgi-bin/viewcvs.cgi/Wrapping/CSwig/IO/itkTkImageViewer2D.cxx?root=Insight&r1=1.2&r2=1.3 [^]