MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010518CMakeCPackpublic2010-04-08 05:502011-01-12 07:26
ReporterGuillaume Duhamel 
Assigned ToEric NOULARD 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.4Fixed in VersionCMake 2.8.4 
Summary0010518: Parameter substitution not turned off for license in STGZ packages
DescriptionIn STGZ packages, parameter substitution is not turned off when displaying the license file. This may end up in a crash when running the generated .sh file as the license file may contain special characters like $ or ` (for instance, the GPL license file contains multiple `).
Steps To Reproduce
Additional InformationI attached a (quite simple) patch to the problem.
TagsNo tags attached.
Relationships
has duplicate 0011788closed Eric NOULARD CPACK_RESOURCE_FILE_LICENSE fails if file contains quotes 
Attached Filespatch cpack-here-doc.patch (416) 2010-04-08 05:50
https://public.kitware.com/Bug/file/3011/cpack-here-doc.patch
Issue History
Date ModifiedUsernameFieldChange
2010-04-08 05:50Guillaume DuhamelNew Issue
2010-04-08 05:50Guillaume DuhamelFile Added: cpack-here-doc.patch
2010-12-14 18:26David ColeAssigned To => Eric NOULARD
2010-12-14 18:26David ColeStatusnew => assigned
2010-12-14 18:26David ColeNote Added: 0023998
2010-12-14 18:55Eric NOULARDNote Added: 0024119
2010-12-14 19:01Eric NOULARDNote Added: 0024123
2010-12-15 15:29Eric NOULARDNote Added: 0024188
2010-12-15 15:29Eric NOULARDStatusassigned => closed
2010-12-15 15:29Eric NOULARDResolutionopen => fixed
2010-12-15 15:29Eric NOULARDFixed in Version => CMake 2.8.4
2011-01-12 07:26David ColeTarget Version => CMake 2.8.4
2011-02-02 16:51Eric NOULARDRelationship addedrelated to 0011788
2011-02-03 02:13Eric NOULARDRelationship deletedrelated to 0011788
2011-02-03 02:14Eric NOULARDRelationship addedhas duplicate 0011788

Notes
(0023998)
David Cole   
2010-12-14 18:26   
Eric,

Does the attached patch look reasonable to you? Have you tried it?

If you don't want it assigned to you, feel free to assign it back to me...

Thanks,
David
(0024119)
Eric NOULARD   
2010-12-14 18:55   
Hi Dave,

Yes it does.
I did some rough test and it works as expected.

I'm not currently on my dev box, I may do some more tests
and push it to next when I'm done.
(0024123)
Eric NOULARD   
2010-12-14 19:01   
OK I confirm the quoting of the so-called "here document" is the usual
way to go, cf:
http://en.wikipedia.org/wiki/Here_document#Unix_Shells [^]

I'll push it when I get my hand on my dev host again.
Feel free to push it yourself before me and close the bug.
(0024188)
Eric NOULARD   
2010-12-15 15:29   
Merge topic 'CPackSTGZ-NoSubstitution' into next

07bd856 CPackSTGZ quote here-doc, fix bug10518

Pushing upstream next
To git@cmake.org:cmake.git