MantisBT - ITK | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0010443 | ITK | public | 2010-03-19 12:17 | 2010-11-15 06:07 | |
| Reporter | Marius Staring | ||||
| Assigned To | Luis Ibanez | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | OS | OS Version | |||
| Product Version | |||||
| Target Version | Fixed in Version | ITK-4-A3 | |||
| Resolution Date | 2010-11-11 | ||||
| Sprint | |||||
| Sprint Status | backlog | ||||
| Summary | 0010443: VectorGradientMagnitudeImageFilter issues | ||||
| Description | The VectorGradientMagnitudeImageFilter class has protected Get and Set functions, such as: /** Get/Set the neighborhood radius used for gradient computation */ itkGetConstReferenceMacro( NeighborhoodRadius, RadiusType ); itkSetMacro( NeighborhoodRadius, RadiusType ); Since to my knowledge no class derives from VectorGradientMagnitudeImageFilter, and because it just makes sense, these functions should probably be public. --------------------------------------------------------------- The 3D tests for this class seem to have two parameters switched, see lines 739 - 753 of Insight\Testing\Code\BasicFilters\CMakeLists.txt: These lines should probably read ADD_TEST(itkVectorGradientMagnitudeImageFilterTest2 ${BASIC_FILTERS_TESTS3} --compare ${ITK_DATA_ROOT}/Baseline/BasicFilters/VectorGradientMagnitudeImageFilterTest2.png ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2.png itkVectorGradientMagnitudeImageFilterTest2 ${ITK_DATA_ROOT}/Input/VHFColor.mhd ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2.png 0 5) ADD_TEST(itkVectorGradientMagnitudeImageFilterTest2b ${BASIC_FILTERS_TESTS3} --compare ${ITK_DATA_ROOT}/Baseline/BasicFilters/VectorGradientMagnitudeImageFilterTest2b.png ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2b.png itkVectorGradientMagnitudeImageFilterTest2 ${ITK_DATA_ROOT}/Input/VHFColor.mhd ${ITK_TEST_OUTPUT_DIR}/VectorGradientMagnitudeImageFilterTest2b.png 1 5) and not ADD_TEST( .... 5 0 ) and ADD_TEST( .... 5 1 ) Because the parameter argv[3] should be 0 or 1 and not the last parameter (see Insight\Testing\Code\BasicFilters\itkVectorGradientMagnitudeImageFilterTest2.cxx). Solving this will also increase code coverage, since now the function for 3D images EvaluateAtNeighborhood3D() is never called. | ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2010-03-19 12:17 | Marius Staring | New Issue | |||
| 2010-03-19 12:18 | Marius Staring | Status | new => assigned | ||
| 2010-03-19 12:18 | Marius Staring | Assigned To | => Luis Ibanez | ||
| 2010-11-07 01:51 | Luis Ibanez | Note Added: 0022992 | |||
| 2010-11-15 06:07 | Marius Staring | Resolution Date | => 2010-11-11 | ||
| 2010-11-15 06:07 | Marius Staring | Sprint Status | => backlog | ||
| 2010-11-15 06:07 | Marius Staring | Note Added: 0023251 | |||
| 2010-11-15 06:07 | Marius Staring | Status | assigned => closed | ||
| 2010-11-15 06:07 | Marius Staring | Resolution | open => fixed | ||
| 2010-11-15 06:07 | Marius Staring | Fixed in Version | => ITK-4-A3 | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||