MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010316CMakeModulespublic2010-02-22 06:512011-06-17 18:09
ReporterDroscy 
Assigned ToMathieu Malaterre 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0010316: [FindOpenSSL] Patch to handle OpenSSL version checking in find_package(OpenSSL x.y.z) command
DescriptionI've added support for version checking on FindOpenSSL.cmake file, found in CMake pre-release 2.8.1-rc3.

This patch searches for OpenSSL installed version and compares that value with the wanted one:
- if they are compatible the process continue
- if they are not compatible:
  * if REQUIRED option is set, the patch outputs a FATAL_ERROR
  * otherwise outputs a warning message and set OPENSSL_FOUND to FALSE


In addition I've added a way to handle custom OpenSSL installation looking for include files and libraries in the path present in CMake (or system) variable OPENSSL_ROOT_DIR that can be manually set by the user.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch FindOpenSSL-2.8.1-rc3_version-checking.patch (7,063) 2010-02-22 06:51
https://public.kitware.com/Bug/file/2888/FindOpenSSL-2.8.1-rc3_version-checking.patch
patch FindOpenSSL-2.8.2_paths-missing+version-checking.patch (4,316) 2010-07-25 16:16
https://public.kitware.com/Bug/file/3264/FindOpenSSL-2.8.2_paths-missing%2Bversion-checking.patch
Issue History
Date ModifiedUsernameFieldChange
2010-02-22 06:51DroscyNew Issue
2010-02-22 06:51DroscyFile Added: FindOpenSSL-2.8.1-rc3_version-checking.patch
2010-07-25 16:16DroscyNote Added: 0021474
2010-07-25 16:16DroscyFile Added: FindOpenSSL-2.8.2_paths-missing+version-checking.patch
2010-12-14 18:14David ColeAssigned To => Mathieu Malaterre
2010-12-14 18:14David ColeStatusnew => assigned
2010-12-14 18:15David ColeNote Added: 0023996
2011-03-28 11:53Mathieu MalaterreNote Added: 0025928
2011-03-28 11:54Mathieu MalaterreNote Added: 0025929
2011-03-28 11:54Mathieu MalaterreStatusassigned => closed
2011-03-28 11:54Mathieu MalaterreResolutionopen => fixed
2011-03-31 08:12Brad KingNote Added: 0025979
2011-03-31 08:12Brad KingStatusclosed => feedback
2011-03-31 08:12Brad KingResolutionfixed => reopened
2011-03-31 09:18Brad KingNote Added: 0025980
2011-03-31 10:24Brad KingNote Added: 0025982
2011-03-31 10:24Brad KingStatusfeedback => closed
2011-03-31 10:24Brad KingResolutionreopened => fixed
2011-06-17 18:09David ColeFixed in Version => CMake 2.8.5
2011-06-17 18:09David ColeTarget Version => CMake 2.8.5

Notes
(0021474)
Droscy   
2010-07-25 16:16   
The new patch is for CMake 2.8.2 and includes the patch that I've attached here http://public.kitware.com/Bug/view.php?id=11035 [^]
(0023996)
David Cole   
2010-12-14 18:15   
Mathieu,

Again, if you want to take a crack at this bug, go for it. If not, feel free to assign it back to me.

Thanks,
David
(0025928)
Mathieu Malaterre   
2011-03-28 11:53   
Your patch is fantastic ! I simply added the missing documentation for openssl_version.

Thanks a bunch !
(0025929)
Mathieu Malaterre   
2011-03-28 11:54   
$ git push stage HEAD
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 1.13 KiB, done.
Total 4 (delta 3), reused 0 (delta 0)
To git@cmake.org:stage/cmake.git
 * [new branch] HEAD -> fixbug_0010316
(0025979)
Brad King   
2011-03-31 08:12   
Pushing to the stage is not enough to call this closed.

It at least needs to be merged to 'next'.
(0025980)
Brad King   
2011-03-31 09:18   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b4c3ff7c [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0fb5142e [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a164649f [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a091ba61 [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=112f1dd7 [^]
(0025982)
Brad King   
2011-03-31 10:24   
The commits listed in 0010316:0025980 have been merged.