MantisBT - CMake
View Issue Details
0010206CMakeCMakepublic2010-01-29 17:152011-01-12 07:17
Jeremy Nicholl 
Brad King 
normalminoralways
closedfixed 
CMake-2-8 
CMake 2.8.4CMake 2.8.4 
0010206: UNC paths in MSYS include directories cause dependency resolution failures
Using a UNC path in MSYS (e.g. //someserver/somedir) in the include path causes depend.make to fail to locate header files in /someserver/somedir, truncating the first slash.
The patch in the additional information fixes the issue. Checking back through the CVS logs, it looks like the pos variable was originally initialized to 1 (see version 1.113 of the file) but was then removed in 1.114 and set to 0 in 1.115.
kwsys_stl::string SystemTools::ConvertToUnixOutputPath(const char* path)
{
  kwsys_stl::string ret = path;
  
  // remove // except at the beginning might be a cygwin drive
- kwsys_stl::string::size_type pos=0;
+ kwsys_stl::string::size_type pos=1;
  while((pos = ret.find("//", pos)) != kwsys_stl::string::npos)
    {
    ret.erase(pos, 1);
    }
No tags attached.
Issue History
2010-01-29 17:15Jeremy NichollNew Issue
2010-12-14 17:49David ColeAssigned To => Brad King
2010-12-14 17:49David ColeStatusnew => assigned
2010-12-14 17:50David ColeNote Added: 0023991
2010-12-14 18:14Brad KingNote Added: 0023995
2010-12-14 18:14Brad KingStatusassigned => closed
2010-12-14 18:14Brad KingResolutionopen => fixed
2011-01-12 07:17David ColeFixed in Version => CMake 2.8.4
2011-01-12 07:17David ColeTarget Version => CMake 2.8.4

Notes
(0023991)
David Cole   
2010-12-14 17:50   
Opinion on this wide-reaching kwsys code change.....?
(0023995)
Brad King   
2010-12-14 18:14   
Ugh, dumb mistake on my part 5 years ago. Fixed:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3a14b6e5 [^]