MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010020CMakeModulespublic2009-12-10 01:222010-09-09 23:55
ReporterClinton Stimpson 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0010020: BundleUtilities doesn't copy necessary parts of a framework
DescriptionThere are other parts of a framework that need to be copied by BundleUtilities.
If Resources exists, it should be copied, without the user of the script helping it be copied.

Maybe some level of control on copying parts of the framework would be nice.
Maybe the whole framework is copied with a way to exclude parts of it.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0009723closed David Cole fixup_bundle in BundleUtilities.cmake doesn't properly copy openscenegraph frameworks. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-10 01:22Clinton StimpsonNew Issue
2010-07-23 06:15David ColeStatusnew => assigned
2010-07-23 06:15David ColeAssigned To => David Cole
2010-07-23 06:17David ColeRelationship addedrelated to 0009723
2010-07-27 14:08David ColeNote Added: 0021495
2010-07-27 14:08David ColeStatusassigned => resolved
2010-07-27 14:08David ColeResolutionopen => fixed
2010-07-28 00:04Clinton StimpsonNote Added: 0021509
2010-07-28 00:04Clinton StimpsonStatusresolved => closed
2010-09-09 23:55David ColeFixed in Version => CMake 2.8.3
2010-09-09 23:55David ColeTarget Version => CMake 2.8.3

Notes
(0021495)
David Cole   
2010-07-27 14:08   
Fixed in CMake 'next' by this commit:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=979972f98895cf804d2b606162f0f8f40fbd1da9 [^]

Clinton,

I decided it was easiest to:
by default: copy just the dylib for the framework, and then add the "Resources" too if they exist...

But if you really want to, you can set BU_COPY_FULL_FRAMEWORK_CONTENTS to ON and it will copy the full framework into the bundle.

If somebody has a suggestion for any other strategies that might work, I'd be open to hearing them.

Does this commit fix the issue in your eyes, Clint? Or is there more that needs to be done on it?

Thanks...
(0021509)
Clinton Stimpson   
2010-07-28 00:04   
Looks good to me. I also did a quick test on cmake itself.