<div dir="ltr">Hi Niels,<div><br></div><div>I merged your change last night.</div><div><br></div><div>Thank you for contributing to VTK!</div><div><br></div><div>Best regards,</div><div>Cory</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 26, 2015 at 4:19 PM, Niels Dekker - address until 2018 <span dir="ltr"><<a href="mailto:niels_dekker_address_until_2018@xs4all.nl" target="_blank">niels_dekker_address_until_2018@xs4all.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi again, Cory,<br>
<br>
Please check my merge request, and please merge, if you think it's fine: <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/704" rel="noreferrer" target="_blank">https://gitlab.kitware.com/vtk/vtk/merge_requests/704</a><br>
<br>
Kind regards, Niels<div><div class="h5"><br>
<br>
On 23 Sep 2015 6:40 PM, I wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
Hi Cory,<br>
<br>
Thanks for the information. Actually, explaining why exactly those<br>
warnings appear might be the hardest part! It looks like the following<br>
is happening, for a subproject that was meant to have suppressed<br>
warnings:<br>
1. For such a subproject, VTK replaces any compiler option<br>
regarding warning-levels from CMAKE_C_FLAGS and CMAKE_CXX_FLAGS by<br>
'/w' and '-w'.<br>
2. CMake then created a Visual Studio project file ("*.vcxproj")<br>
that does not have any <WarningLevel> XML tag. Instead, CMake adds<br>
'/w' and '-w' to the <AdditionalOptions> XML tag.<br>
3. Visual Studio finds out that the <WarningLevel> tag is missing,<br>
and so it adds warning-level 1 ('/W1') as its default warning-level.<br>
However, it also adds those '/w' and '-w' from <AdditionalOptions> to<br>
the command-line.<br>
4. The C++ compiler (cl.exe) gets '/W1, as well as '/w' and '-w',<br>
so it complains about overriding '/W1' with '/w'.<br>
<br>
Fortunately this problem does not occur when VTK uses '/W0', instead<br>
of '/w' or '-w'!<br>
<br>
Kind regards, Niels<br>
<br>
Cory Quammen wrote on September 23, 2015, 16:22:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
Niels,<br>
<br>
I saw that you contributed to ITK via gerrit. Contributing to VTK is<br>
similar, but it uses gitlab instead of gerrit. I wouldn't bother with<br>
a bug report for this issue - just explaining why the warnings appear<br>
in the commit message is sufficient.<br>
<br>
Thanks for offering to contribute! I will watch for your patch and<br>
shepherd it through the review process.<br>
<br>
Best,<br>
Cory<br>
<br>
On Wed, Sep 23, 2015 at 10:16 AM, Niels Dekker wrote:<br>
<br>
Hi Cory,<br>
<br>
Thank you! When I have time (hopefully before next Sunday), I'll<br>
try to contribute the patch via your gitlab contribution process.<br>
Is the process similar to ITK? And do you think I should create a<br>
"ticket" or "bug report" for this little issue?<br>
<br>
If I can't get it to work (or if it takes me too much time), I<br>
hope someone else can do the patch for me, next week or so...<br>
<br>
Kind regards, Niels<br>
<br>
PS Also thanks to Audrius for the support :-)<br>
<br>
Cory Quammen wrote on September 23, 2015, 15:54:<br>
<br>
Hi Niels,<br>
<br>
This does sound like a good patch. Would you mind contributing<br>
it via<br>
our gitlab contribution process? Please see [1].<br>
<br>
[1]<br>
<a href="https://gitlab.kitware.com/vtk/vtk/blob/master/CONTRIBUTING.md" rel="noreferrer" target="_blank">https://gitlab.kitware.com/vtk/vtk/blob/master/CONTRIBUTING.md</a><br>
<br>
Thank you,<br>
Cory<br>
<br>
On Wed, Sep 23, 2015 at 9:46 AM, Niels Dekker wrote:<br>
<br>
Does anyone here think it would be nice to fix these MSVC<br>
warnings?<br>
<br>
Basically it's just a matter of replacing '/w' and '-w'<br>
by '/W0',<br>
in various CMake files of the VTK source tree, according<br>
to the<br>
patch/diff-file I attached last Sunday.<br>
<br>
<br></div></div><span class="">
--<br>
Cory Quammen<br>
R&D Engineer<br>
Kitware, Inc.<br>
</span></blockquote></blockquote><div class="HOEnZb"><div class="h5">
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the VTK FAQ at: <a href="http://www.vtk.org/Wiki/VTK_FAQ" rel="noreferrer" target="_blank">http://www.vtk.org/Wiki/VTK_FAQ</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtkusers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtkusers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtkusers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtkusers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Cory Quammen<br>R&D Engineer<br>Kitware, Inc.</div>
</div>