<div dir="ltr"><div><div><div>Hi Jin,<br><br></div>Thanks for looking into this. Some instructions for contributing code to VTK are at <a href="http://www.vtk.org/Wiki/VTK/Git/Develop">http://www.vtk.org/Wiki/VTK/Git/Develop</a>. After you push your code to gerrit for review, you'll want to assign a reviewer. People that modified that code are most appropriate. Assign them at the change AND topic level in gerrit to make sure they get notified by email for the code review request -- it's a bit clunky and people haven't always gotten emails for code reviews if you just add them under one of change and topic but I can't remember which one doesn't send the email.<br><br></div>Regards,<br></div>Andy<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 29, 2014 at 2:32 AM, Zhou, Jin <span dir="ltr"><<a href="mailto:Jin.Zhou@amd.com" target="_blank">Jin.Zhou@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal">Hi there,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Currently I find a bug in vtkOpenGLProjectedTetrahedraMapper.cxx:line 470,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">void vtkOpenGLProjectedTetrahedraMapper::Render(vtkRenderer *renderer,<u></u><u></u></p>
<p class="MsoNormal"> vtkVolume *volume)<u></u><u></u></p>
<p class="MsoNormal">{<u></u><u></u></p>
<p class="MsoNormal">…<u></u><u></u></p>
<p class="MsoNormal">glTexImage2D(GL_TEXTURE_2D, 0, GL_INTENSITY, TEXRES, TEXRES, 1, GL_RED,<u></u><u></u></p>
<p class="MsoNormal"> GL_FLOAT, texture);<u></u><u></u></p>
<p class="MsoNormal">…<u></u><u></u></p>
<p class="MsoNormal">}<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">According to the opengl spec, the ‘border’ parameter of glTexImage2D must be 0:<u></u><u></u></p>
<p class="MsoNormal"><code><span style="font-size:10.0pt">void</span></code><span><span style="font-size:10.0pt;font-family:"Courier New""> </span></span><strong><span style="font-size:10.0pt;font-family:"Courier New"">glTexImage2D</span></strong><code><span style="font-size:10.0pt">(</span></code>GLenum<span> </span><var><span style="font-family:"Verdana","sans-serif"">target</span></var>, GLint<span> </span><var><span style="font-family:"Verdana","sans-serif"">level</span></var>, GLint<span> </span><var><span style="font-family:"Verdana","sans-serif"">internalFormat</span></var>, GLsizei<span> </span><var><span style="font-family:"Verdana","sans-serif"">width</span></var>, GLsizei<span> </span><var><span style="font-family:"Verdana","sans-serif"">height</span></var>, GLint<span> </span><var><span style="font-family:"Verdana","sans-serif"">border</span></var>, GLenum<span> </span><var><span style="font-family:"Verdana","sans-serif"">format</span></var>, GLenum<span> </span><var><span style="font-family:"Verdana","sans-serif"">type</span></var>, const
GLvoid *<span> </span><var><span style="font-family:"Verdana","sans-serif"">data</span></var><code><span style="font-size:10.0pt">)</span></code>;<u></u><u></u></p>
<p class="MsoNormal" style="margin-top:11.25pt"><i><span style="font-size:10.0pt;font-family:"Courier New";color:black">border</span></i><span style="font-size:12.0pt;font-family:"Verdana","sans-serif";color:black"><u></u><u></u></span></p>
<p class="MsoNormal" style="margin-right:0in;margin-bottom:6.0pt;margin-left:.5in">
<span style="font-size:12.0pt;font-family:"Verdana","sans-serif";color:black">This value must be 0.<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Can anybody tell me how to send the patch to VTK community ?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Best Regards,<u></u><u></u></p>
<p class="MsoNormal">Jin<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the VTK FAQ at: <a href="http://www.vtk.org/Wiki/VTK_FAQ" target="_blank">http://www.vtk.org/Wiki/VTK_FAQ</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtkusers" target="_blank">http://markmail.org/search/?q=vtkusers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtkusers" target="_blank">http://public.kitware.com/mailman/listinfo/vtkusers</a><br>
<br></blockquote></div><br></div>