<div dir="ltr">Or use colors like TSA. This topic is threat level Orange ;-)</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 4, 2017 at 11:51 AM, Berk Geveci <span dir="ltr"><<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">We could keep +2 and +3 but make +1 sufficient for merging... Just saying.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 3, 2017 at 5:24 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I rather like that distinction, i.e. the difference between merely "looks fine" vs "looks fine, I tried it, I know this code, I authoritatively approve".<br>
<br>
But I'm not super bothered about it all...<br>
<span class="m_5055324950357722957HOEnZb"><font color="#888888"><br>
Sean<br>
</font></span><div class="m_5055324950357722957HOEnZb"><div class="m_5055324950357722957h5"><br>
<br>
On Tue, 3 Oct 2017 23:17:34 +0200, Jon Haitz Legarreta said:<br>
<br>
>Although I use Mathieu's convention, I'd be OK if we switched to +1/-1 only.<br>
><br>
>JON HAITZ<br>
><br>
>--<br>
><br>
><br>
><br>
>On 3 October 2017 at 16:34, Mathieu Westphal<br>
><<a href="mailto:mathieu.westphal@kitware.com" target="_blank">mathieu.westphal@kitware.com</a><wbr>> wrote:<br>
>> Hi<br>
>><br>
>> My scale was shifted by +1 actually.<br>
>> What i'm using is the following :<br>
>><br>
>> +1 or (:+1:) means "I consider the changed ready for integration"<br>
>> +2 means "I consider the changed ready for integration and have locally<br>
>> tested it and verified it works."<br>
>><br>
>> I'm happy with anything, but I always apreciate when a reviewer go ahead and<br>
>> try out the feature during the review.<br>
>><br>
>> Mathieu Westphal<br>
>><br>
>> On Tue, Oct 3, 2017 at 4:29 PM, David E DeMarle <<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>><br>
>> wrote:<br>
>>><br>
>>> Our current rule is:<br>
>>><br>
>>> <a href="https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/" rel="noreferrer" target="_blank">https://gitlab.kitware.com/vtk<wbr>/vtk/blob/master/Documentation<wbr>/dev/git/</a><br>
><a href="http://develop.md#leading-line" rel="noreferrer" target="_blank">develop.md#leading-line</a><br>
>>><br>
>>> +1 has alway been problematic.<br>
>>> I've never seen a +3 comment in the wild.<br>
>>><br>
>>> What say we simplify to just +1 or -1 with words for everything else we<br>
>>> need to say?<br>
>>><br>
>>> Any +1's out there for this suggestion?<br>
>>> --<br>
>>> David E DeMarle<br>
>>> Kitware, Inc.<br>
>>> Principal Engineer<br>
>>> 21 Corporate Drive<br>
>>> Clifton Park, NY 12065-8662<br>
>>> Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a><br>
<br>
<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
<br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Ken Martin PhD<div>Distinguished Engineer<br><span style="font-size:12.8px">Kitware Inc.</span><br></div><div>28 Corporate Drive<br>Clifton Park NY 12065<br><div><br></div><div><span style="font-size:10pt;font-family:Tahoma,sans-serif">This communication,
including all attachments, contains confidential and legally privileged
information, and it is intended only for the use of the addressee. Access to this email by anyone else is
unauthorized. If you are not the intended recipient, any disclosure, copying,
distribution or any action taken in reliance on it is prohibited and may be
unlawful. If you received this communication in error please notify us
immediately and destroy the original message.
Thank you.</span></div></div></div></div></div>
</div>